search

YosefLab / PopV

MIT License
23 stars 8 forks source link

Support for anndata 0.9.x #30

Closed DriesSchaumont closed 1 year ago

DriesSchaumont commented 1 year ago

Hi! I was wondering if there are any plans to support anndata version 0.9.0?

Thanks! Dries

canergen commented 1 year ago

Thanks for your interest in PopV. PopV itself works with newer anndata versions. The only issue is the tutorial notebook. This would require retraining the reference datasets, which is planned but without ETA for now.

DriesSchaumont commented 1 year ago

Hi @cane11

Good to know that popV supports anndata 0.9.x. However, when installing popV from pypi, I get the error:

Screenshot 2023-07-07 at 21 35 14

Is there an issue with the version uploaded to pypi?

canergen commented 1 year ago

I am able to update anndata after installing PopV (this should be the correct order - pypi will complain about it but it shouldn't break things). I might spend some time changing the concatenation function soon'ish. Anndata since 0.9 doesn't cast the type and this fails during concatenation.