Closed yurivict closed 1 year ago
Please try running Yoshimi with the following command:
yoshimi -i
This will run Yoshimi headless, so will tell us if it's a GUI issue or within the main code.
You should get full CLI access, and normal MIDI behaviour.
-- Will J Godfrey {apparently now an 'elderly'} https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song.
yoshimi -i
doesn't crash.
That narrows it down.
In /home/will/yoshimi-code/src/UI/Themes.h
change line 204 to: const int COLOURLIST = 114;
Please let me know if that fixes it. If so, I push a full bugFix release.
-- Will J Godfrey {apparently now an 'elderly'} https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song.
It still crashes with this change.
In this line:
2327├─────────────> setColourLine(colourData[lineCount + 1], lineCount, 1); // we don't want the greyscale line!
it reads the element number 122 (lineCount=121) from the array colourData that only has 120 elements. This causes the crash.
This get weirder by the minute!
This is what the group of lines should be: int lineCount = 0; while (colourData[lineCount + 1].substr(0, 7) != "=======") { setColourLine(colourData[lineCount + 1], lineCount, 1); // we don't want the greyscale line! ++ lineCount; }
Note the line of '=' here, not '-'
How that manages to work here is one of life's mysteries.
-- Will J Godfrey {apparently now an 'elderly'} https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song.
I suggest making this array std::vector<std::string>>
and iterating using vector's iterators.
IMO you should resolve this issue and make a new release with the fix.
Thanks for the suggestion, however since the structure is now a fixed size, it is simpler to just change this into a 'for' loop. We should have done that some time ago. There will be a bugfix release as soon as the work is completed and exhaustively tested.
Thank you for your assistance with this.
-- Will J Godfrey {apparently now an 'elderly'} https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song.
2.3.0.2 doesn't crash like this. Was this fixed, or this is accidental?
On Sat, 22 Jul 2023 19:46:09 -0700 @." @.> wrote:
2.3.0.2 doesn't crash like this. Was this fixed, or this is accidental?
Yes. This is now fixed in 2.3.0.2. Sorry, I forgot to report it!
-- Will J Godfrey {apparently now an 'elderly'} https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song.
No problem! Thank you.
Version: 2.3.0 FreeBSD 13.2