Change the github icon - Githubissues

YoshithaRathnayake / NEW-YOSHITHA-WEBSITE

This is My New Official Website

https://YoshithaRathnayake.github.io/NEW-YOSHITHA-WEBSITE

16 stars 33 forks source link

Change the github icon #181

Closed Rishav1707 closed 1 year ago

Rishav1707 commented 1 year ago

Purpose

The purpose of this Pull Request is to fix #178

Goals

This feature will fix the GitHub icons transparency in social media icons section.

Approach

Replacing the required png of GitHub icons.

Screenshots

Screenshot 2022-12-14 074730

Preview Link

https://pr-181-NEW-YOSHITHA-WEBSITE.surge.sh/

Checklist

[x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[x] I have read and understood the development best practices guidelines
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Related PRs

## Test environment ## Learning

Rishav1707 commented 1 year ago

Screenshot 2022-12-14 175229 How's this?? @YoshithaRathnayake

Rishav1707 commented 1 year ago

That's not matching bro @Rishav1707

But @YoshithaRathnayake all the GitHub icons expect this one is transparent and matches with the about section background.

YoshithaRathnayake commented 1 year ago

That's not matching bro @Rishav1707

But @YoshithaRathnayake all the GitHub icons expect this one is transparent and matches with the about section background.

It's not in the about section @Rishav1707 can you remove this icon and put that other one I'll merge this

Rishav1707 commented 1 year ago

That's not matching bro @Rishav1707

But @YoshithaRathnayake all the GitHub icons expect this one is transparent and matches with the about section background.

It's not in the about section @Rishav1707 can you remove this icon and put that other one I'll merge this

Done @YoshithaRathnayake

Rishav1707 commented 1 year ago

@YoshithaRathnayake Review this change...

Rishav1707 commented 1 year ago

Done @YoshithaRathnayake

YoshithaRathnayake commented 1 year ago

@Rishav1707 As a best practise we don't use past tense for the commits so, I hope you won't put the commit text in past tense in future

Rishav1707 commented 1 year ago

@Rishav1707 As a best practise we don't use past tense for the commits so, I hope you won't put the commit text in past tense in future

OK @YoshithaRathnayake