YosysHQ / apicula

Project Apicula 🐝: bitstream documentation for Gowin FPGAs
MIT License
462 stars 66 forks source link

Install gowin_pll tool #192

Closed whitequark closed 1 year ago

whitequark commented 1 year ago

Fixes #191.

I implemented this in a somewhat cursed way where it does sys.exit(0) because otherwise the caller (the script installed by setuptools) would crash trying to call the module. This minimizes the diff though.

pepijndevos commented 1 year ago

I'd rather wrap it in a main function and add the usual if name == main like the other scripts

On Fri, 4 Aug 2023, 16:47 Catherine @.***> wrote:

@whitequark https://github.com/whitequark requested your review on: #192 https://github.com/YosysHQ/apicula/pull/192 Install gowin_pll tool.

— Reply to this email directly, view it on GitHub https://github.com/YosysHQ/apicula/pull/192#event-10010313414, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJFIKEQPCGEFOSXDN4RQ3XTUDQPANCNFSM6AAAAAA3EKBCYY . You are receiving this because your review was requested.Message ID: @.***>

whitequark commented 1 year ago

Done

pepijndevos commented 1 year ago

Thank you!