Fix #219: Python3.8 compatiblity

YosysHQ / apicula

Project Apicula 🐝: bitstream documentation for Gowin FPGAs

MIT License

474 stars 66 forks source link

Fix #219: Python3.8 compatiblity #221

Closed DavidVentura closed 9 months ago

DavidVentura commented 9 months ago

My changes to the DAT file parser do not run on Python3.8 and the validation tests passed, as they run on Python3.9.

If bumping the requirement to 3.9 is not reasonable, this PR adds a sanity check by executing gowin_pack on 3.8. I added the check to the pypi job to prevent the publish step from being runnable, but I could also move this into a new job that runs on 3.8

pepijndevos commented 9 months ago

Oh that's a great idea I'm sure the foss cad suite people will be pleased