search

YosysHQ / apicula

Project Apicula 🐝: bitstream documentation for Gowin FPGAs
MIT License
497 stars 68 forks source link

Fix regex #259

Closed max-kudinov closed 4 months ago

max-kudinov commented 4 months ago

Fixed regex for shorting device name, so it would work with GW2A series.

Also renamed luts to num, because this number doesn't necessarily represent number of luts (18 for 20k LUTs chip)

pepijndevos commented 4 months ago

Great work!

Maybe we should update the makefile with the chip name to test this change?

https://github.com/YosysHQ/apicula/blob/f19de5230dc1f88c36b6d60f38ae874f1e697ad4/examples/himbaechel/Makefile.himbaechel#L215

max-kudinov commented 4 months ago

Great work!

Maybe we should update the makefile with the chip name to test this change?

https://github.com/YosysHQ/apicula/blob/f19de5230dc1f88c36b6d60f38ae874f1e697ad4/examples/himbaechel/Makefile.himbaechel#L215

It seems that this makefile uses short names for all chips, including GW1N*. In that case I think that all names should be changed to their full version, not just GW2A. What do you think about it?

And by the way, what's the difference between examples and examples/himbaechel directories?

pepijndevos commented 4 months ago

Eh that's fair. It could be a useful change, but could be a separate PR.

The difference is example uses nextpnr-gowin while examples/himbaechel uses that.

max-kudinov commented 4 months ago

Then the names should be changed in both examples and examples/himbaechel makefiles, cause gowin_pack call is the same. I can make a separate PR with it.