YosysHQ / apicula

Project Apicula 🐝: bitstream documentation for Gowin FPGAs
MIT License
496 stars 67 forks source link

Fix SyntaxWarning #286

Open eamanu opened 1 month ago

eamanu commented 1 month ago

This commit remove an invalid escape sequence.

Error originally reported here [0]

[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1085325

pepijndevos commented 1 month ago

Could you elaborate on the python version compatibility of the old and new syntax?

Sent from Proton Mail Android

-------- Original Message -------- On 22/10/2024 02:04, Emmanuel Arias wrote:

This commit remove an invalid escape sequence.


You can view, comment on, or merge this pull request online at:

https://github.com/YosysHQ/apicula/pull/286

Commit Summary

File Changes

(1 file)

Patch Links:

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

eamanu commented 1 month ago

Hi!

Sorry, I don't know what you mean, but invalid escape sequence were deprecated in py3.6[0]. In python3.12 the DeprecationWarning was replaced by a SyntaxWarning[1].

This commit convert the literal string in a raw.

[0] https://github.com/python/cpython/issues/98401 [1] https://docs.python.org/3/whatsnew/3.12.html#other-language-changes

pepijndevos commented 4 weeks ago

Thanks. I just found my own answer, the fr combination is as old as format strings themselves so there is no backwards compatibility problem. Lgtm!

Sent from Proton Mail Android

-------- Original Message -------- On 25/10/2024 03:18, Emmanuel Arias wrote:

Hi!

Sorry, I don't know what you mean, but invalid escape sequence were deprecated in py3.6[0]. In python3.12 the DeprecationWarning was replaced by a SyntaxWarning[1].

This commit convert the literal string in a raw.

[0] python/cpython#98401 [1] https://docs.python.org/3/whatsnew/3.12.html#other-language-changes

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>