Fix chipdb read failure on Windows

YosysHQ / arachne-pnr

Place and route tool for FPGAs

MIT License

414 stars 72 forks source link

Fix chipdb read failure on Windows #29

Closed benpye closed 8 years ago

benpye commented 8 years ago

Windows will convert \n to \r\n and vice versa on read/write in text mode, binary mode must be stated explicitly to prevent this. This fixes #28

benpye commented 8 years ago

Not sure why the CI build failed? @cseed

EDIT: Icestorm has changed it's behaviour and the chipdb-8/1k.txt files are being placed in a different directory.

Obijuan commented 8 years ago

I can confirm that this patch works. @cseed or @cliffordwolf , could you please have a look and merge it if you find it is ok? It fixes issue #28 Thanks a lot

cliffordwolf commented 8 years ago

@Obijuan looks ok to me, but I can't merge it, only @cseed can.

Obijuan commented 8 years ago

Thanks a lot! :-)