robtaylor
commented
1 year ago as a note, would be ideal if there was a regular CI thats builds without using previous releases to test this sort of thing!
Open robtaylor opened 1 year ago
robtaylor
commented
1 year ago as a note, would be ideal if there was a regular CI thats builds without using previous releases to test this sort of thing!
robtaylor
commented
1 year ago this dirty hack seems to do the job:
@@ -420,6 +420,7 @@ def executeBuild(target, arch, prefix, build_dir, output_dir, nproc, pack_source
'--user', '{}:{}'.format(os.getuid(), os.getgid()),
'-v', '/tmp:/tmp',
'-v', '{}:/work'.format(cwd),
+ '-v', '{}:{}'.format(os.path.join(cwd, os.path.split(output_dir)[0], "python3",os.path.relpath(prefix,"/")), prefix),
'-w', os.path.join('/work', os.path.relpath(build_dir, os.getcwd())),
]
for i, j in env.items():
mmicko
commented
1 year ago Hi @robtaylor, thanks for report. You are right, looks like things got broken meanwhile. Found a way to prevent this by setting proper variables when compiling packages. Testing all locally now so expect it soon.
robtaylor
commented
1 year ago ah cool, thanks @mmicko!
robtaylor
commented
1 year ago Relatedly, is it a goal that pip install would work when you're in the oss-build environment? currently a user would hit the same problem there.
robtaylor
commented
1 year ago nasty hack approach needed a tweak. I'll use this locally for now, but would be great to fix this issue properly! Might be worth checking out crossenv
diff --git a/src/base.py b/src/base.py
index 47d8945..522cbbf 100644
--- a/src/base.py
+++ b/src/base.py
@@ -414,13 +414,16 @@ def executeBuild(target, arch, prefix, build_dir, output_dir, nproc, pack_source
scriptfile.flush()
+ host_prefix = os.path.join(cwd, os.path.split(output_dir)[0], "python3",os.path.relpath(prefix,"/"))
+ os.makedirs(host_prefix, exist_ok=True)
+
log_step("Compiling ...")
params = ['docker',
'run', '--rm',
'--user', '{}:{}'.format(os.getuid(), os.getgid()),
'-v', '/tmp:/tmp',
'-v', '{}:/work'.format(cwd),
- '-v', '{}:{}'.format(os.path.join(cwd, os.path.split(output_dir)[0], "python3",os.path.relpath(prefix,"/")), prefix),
+ '-v', '{}:{}'.format(host_prefix, prefix),
'-w', os.path.join('/work', os.path.relpath(build_dir, os.getcwd())),
]
for i, j in env.items():
Appears to be an issue with prefix being '/yosyshq'. This makes it through to all the sysconfig setup. Maybe a solution is bindmounting /yosyshq appropriately?