search

YosysHQ / oss-cad-suite-build

Multi-platform nightly builds of open source digital design and verification tools
ISC License
742 stars 67 forks source link

Added verilator hotfix #89

Closed sifferman closed 7 months ago

sifferman commented 7 months ago

I added a patch file "default/patches/verilator_patches.py" to hard-code CFG_CXXFLAGS_COROUTINES="-fcoroutines" and HAVE_COROUTINES=1 in "configure.ac".

I ran ./builder.py build --target=verilator --arch=linux-x64. verilator -V correctly gave COROUTINES = 1.

"default/patches/verilator_patches.py" should be removed once the Ubuntu docker file is updated to include g++>=10: https://github.com/YosysHQ/oss-cad-suite-build/issues/84#issuecomment-1795904993.

Also, I removed the existing patch for darwin because it works fine without it as far as I can tell. Could this be confirmed? (The patch file came from verilator/verilator@49353784, Nov 29, 2018, which seems very old).

Thanks!

sifferman commented 7 months ago

@mmicko Could you check on this when you get a chance? I am happy to make adjustments as needed!

mmicko commented 7 months ago

Sorry for delay on this one, was a busy week.

sifferman commented 7 months ago

Thanks!