search

YosysHQ / yosys

Yosys Open SYnthesis Suite
https://yosyshq.net/yosys/
ISC License
3.42k stars 874 forks source link

clk2fflogic: Fix handling of $check cells #4211

Closed jix closed 7 months ago

jix commented 7 months ago

Fixes a bug in the handling of the recently introduced $check cells. Both $check and $print cells in clk2fflogic are handled by the same code and the existing tests for that were only using $print cells. This missed a bug where the additional A signal of $check cells that is not present on $print cells was dropped due to a typo, rendering $check cells non-functional.

Also updates the tests to explicitly cover both cell types such that they would have detected the now fixed bug.

povik commented 7 months ago

Great we got some tests to cover this!