search

YosysHQ / yosys

Yosys Open SYnthesis Suite
https://yosyshq.net/yosys/
ISC License
3.31k stars 860 forks source link

MAX10 updates #4262

Open rherveille opened 4 months ago

rherveille commented 4 months ago

Fixed altsyncram data/address width parameters Added DSP (mult) support Updated synth_intel script (~20% higher performance)

rherveille commented 4 months ago

Do you want me to create a new pull request?

Richard

From: Martin Povišer @.> Date: Wednesday, 6 March 2024 at 01:54 To: YosysHQ/yosys @.> Cc: Richard Herveille @.>, Author @.> Subject: Re: [YosysHQ/yosys] MAX10 updates (PR #4262)

@povik commented on this pull request.

In techlibs/intel/synth_intel.cchttps://github.com/YosysHQ/yosys/pull/4262#discussion_r1514167210:

           if (check_label("coarse")) {

+// run("synth -run coarse");

It's a nit, but please don't leave commented-out pieces of code in.

— Reply to this email directly, view it on GitHubhttps://github.com/YosysHQ/yosys/pull/4262#pullrequestreview-1919273466, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYKSCOUYZK2Q42G7V7MCRLYW3RVBAVCNFSM6AAAAABEIF2YSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJZGI3TGNBWGY. You are receiving this because you authored the thread.Message ID: @.***>

povik commented 4 months ago

Do you want me to create a new pull request?

You don't need to, you can change the existing one if you push more commits to the branch from which you have the pull request open (in your case this one).

rherveille commented 3 months ago

Done

Richard

From: Martin Povišer @.> Date: Thursday, 7 March 2024 at 23:14 To: YosysHQ/yosys @.> Cc: Richard Herveille @.>, Author @.> Subject: Re: [YosysHQ/yosys] MAX10 updates (PR #4262)

Do you want me to create a new pull request?

You don't need to, you can change the existing one if you push more commits to the branch from which you have the pull request open (in your case this onehttps://github.com/RoaLogic/yosys/tree/master).

— Reply to this email directly, view it on GitHubhttps://github.com/YosysHQ/yosys/pull/4262#issuecomment-1985161438, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYKSCL2JQKLAB2TTUL5UQDYXFQNBAVCNFSM6AAAAABEIF2YSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBVGE3DCNBTHA. You are receiving this because you authored the thread.Message ID: @.***>