YosysHQ / yosys

Yosys Open SYnthesis Suite
https://yosyshq.net/yosys/
ISC License
3.3k stars 860 forks source link

add support for using ABCs library merging when providing multiple liberty files #4340

Closed gadfort closed 2 months ago

gadfort commented 2 months ago

Changes:

Requirements:

QuantamHD commented 2 months ago

@povik This one is also useful to Google. Any chance the Yosys team could propritize it?

povik commented 2 months ago

I am testing this change against current ABC. When I pass two Liberty files, the cells from the first one get prefixed with L1_ while the cells from the second get no prefix. That looks weird.

I saw there's the read_lib -p option, but we don't use it with neither of the read_lib invocations.

gadfort commented 2 months ago

@povik thanks for checking this. It looks like when the use prefix option was added it didn't account for one of the libraries. I've added a PR to fix that https://github.com/berkeley-abc/abc/pull/287. We shouldn't use the -p since that is what is supposed to add the prefixes to the names, which is not the behavior we want.

povik commented 2 months ago

I've added a PR to fix that https://github.com/berkeley-abc/abc/pull/287.

I will watch that one get merged so we update our fork after that.

We shouldn't use the -p since that is what is supposed to add the prefixes to the names, which is not the behavior we want.

OK, I thought so.

gadfort commented 2 months ago

@povik should have been merged now.

povik commented 2 months ago

Let's go ahead and merge this even if the vendored ABC isn't at the right version yet. There's no harm.