Closed dopamane closed 1 month ago
@dopamane thanks for changes suggestions. Please note there are couple of cases we need to handle here
Last one is special case we need to handle for users not using git but building all from source tarballs. Meta code that should cover this
if abc dir exists
if abc/.gitcommit is not "$Format:%h$"
all fine abc tarball, just exit
else if abc submodule status is "-"
using old abc checkout, remove and initialize
else
all fine
else
ask for submodule init
@dopamane Could you please take a look at https://github.com/YosysHQ/yosys/pull/4386 and if this one works fine for you.
What are the reasons/motivation for this change?
https://github.com/YosysHQ/yosys/issues/4383
Explain how this is achieved.
Add the condition that if
git submodule status abc
results in a string starting with-
then the git submodule is uninitialized.If applicable, please suggest to reviewers how they can test the change.
Clone the repo, run
make
ormake check-git-abc
, examine instructions to initialize the submodule,git submodule update --init
, re-runmake
ormake check-git-abc
and there should not be any error.