These came up when using the experimental incremental interface and are also in code that was recently refactored to support that interface.
What are the reasons/motivation for this change?
This fixes observed crashes when using the incremental interface. In both cases a special case was missed and the specific changes handle the missed special case.
Explain how this is achieved.
Making smt_concat accept anything iterable in addition to tuples and lists, as it is sometimes called with generators.
Avoiding calling smt_extract_mask with a completely empty mask and expecting a useful result, as it returns None in that case.
If applicable, please suggest to reviewers how they can test the change.
The check-sby CI checks should be sufficient to ensure this doesn't regress anything.
These came up when using the experimental incremental interface and are also in code that was recently refactored to support that interface.
What are the reasons/motivation for this change?
This fixes observed crashes when using the incremental interface. In both cases a special case was missed and the specific changes handle the missed special case.
Explain how this is achieved.
smt_concataccept anything iterable in addition to tuples and lists, as it is sometimes called with generators.smt_extract_maskwith a completely empty mask and expecting a useful result, as it returns None in that case.If applicable, please suggest to reviewers how they can test the change.
The
check-sbyCI checks should be sufficient to ensure this doesn't regress anything.