search

YosysHQ / yosys

Yosys Open SYnthesis Suite
https://yosyshq.net/yosys/
ISC License
3.42k stars 872 forks source link

cxxrtl: capi: don't use deprecated invocation. #4433

Closed kivikakk closed 3 months ago

kivikakk commented 3 months ago

The C API uses the deprecated invocation format.

Also correct the deprecation message, and don't suggest a value for a parameter the caller already has.

Assuming neither this nor #4417 gets a response, I'll stop submitting CXXRTL fixes.

whitequark commented 3 months ago

There's a merge conflict.

whitequark commented 3 months ago

Assuming neither this nor #4417 gets a response, I'll stop submitting CXXRTL fixes.

It's not clear to me why but I've not received an email notification for either PR. (I'm subscribed to all events in this repository, I'm a code owner for CXXRTL, and I checked my GitHub settings and haven't found anything there that would prevent it.)

kivikakk commented 3 months ago

That might've been something on my end; should be addressed now. (I was also confused by the lack of notifications while trying to find out where #4417 went, only to find it was merged!)

Conflict has been remedied.

whitequark commented 3 months ago

Thanks!

kivikakk commented 3 months ago

Thank you!