search

YotpoLtd / magento2-module-yotpo-reviews

Open Software License 3.0
23 stars 38 forks source link

Duplicated CSS #158

Closed hobadams closed 5 years ago

hobadams commented 5 years ago

All of the {less} added in the file yotpo/module-review/view/frontend/web/css/source/_module.less is added to both styles-m.css and styles-l.css

By wrapping your code in the following it will only appear in styles-m.css, preventing it from being difficult to override + bloating the css.

& when (@media-common = true) {
YOUR LESS HERE
}

It would be great to see this added to your module.

Thanks

wabakok-zz commented 5 years ago

Hi,

Thanks for pointing this out! I've notified our devs and they are currently reviewing your suggestion.

hobadams commented 5 years ago

@wabakok - Thanks :-)

wabakok-zz commented 5 years ago

@hobadams Appreciate your patience here. We've added your suggestion to our latest version, 2.8.1 which is already live :)

hobadams commented 5 years ago

Thanks,

This is great news!

I'll update the module on the build I'm working on now :-)

Hob Adams Senior Developer [image: Gene Commerce - specialist ecommerce agency] http://gene.co.uk/ [image: Magento Solutions Partner] [image: Magento 2 Solutions Partner] https://magento.com/ T: +44(0) 1273 030390 | 20 Middle Street, Brighton, BN1 1AL [image: Twitter Logo] https://twitter.com/gene_commerce [image: LinkedIn Logo] https://www.linkedin.com/company/gene-commerce gene.co.uk Registered Office: 20 Middle Street, Brighton, BN1 1AL. Registered in England and Wales No.08589522

On Mon, 24 Jun 2019 at 08:25, Guy_at_Yotpo notifications@github.com wrote:

@hobadams https://github.com/hobadams Appreciate your patience here. We've added your suggestion to our latest version, 2.8.1 which is already live :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/YotpoLtd/magento2-module-yotpo-reviews/issues/158?email_source=notifications&email_token=ACI4AOKPB2DOQZLDRAJQW33P4BZFZA5CNFSM4HNKZ5AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYMATCA#issuecomment-504891784, or mute the thread https://github.com/notifications/unsubscribe-auth/ACI4AOKZCQJAKDAKH2DURN3P4BZFZANCNFSM4HNKZ5AA .

hobadams commented 5 years ago

@wabakok - I'll mark this one as resolved :-)