YotpoLtd / magento2-module-yotpo-reviews

Open Software License 3.0
23 stars 38 forks source link

Yotpo Configuration in Single Store mode #164

Closed hobadams closed 4 years ago

hobadams commented 5 years ago

Hey guys,

I'm using 2.8.1 of your module.

I've noticed that some of the store configs don't appear in the admin if you are running on single store mode.

I believe this is because of showInDefault="0". The configs save but isn't visible on store view 0 (in the admin)

Screenshot 2019-06-27 at 11 04 07

Screenshot 2019-06-27 at 11 03 55

So far the fields I can see that this impacts are enabled, app key and app secret.

Thanks

SlavicB commented 5 years ago

Hey @hobadams ,

Those fields disabled by design, Yotpo is configured in a store scope, there is no global scope config. Even with a single store the configuration is done in that store's scope.

hobadams commented 5 years ago

Thanks @SlavicB.

For us the means we can't see the config settings as there is no way to view that store in the admin.

SlavicB commented 5 years ago

Even with a single store you should have a store view, can you please provide a screenshot of the whole page. That's how the page looks in the two different states: Screen Shot 2019-07-02 at 14 04 53 Screen Shot 2019-07-02 at 14 04 20

hobadams commented 5 years ago
Screenshot 2019-07-02 at 14 50 38 Screenshot 2019-07-02 at 14 50 16

Hey @SlavicB these are screen grabs from my admin.

This store is Magento 2.2.3 EE.

It only has 1 store so you don't get the store drop down.

Thanks

Sazoulay commented 5 years ago

Hi @hobadams

Even in a single store view mode, you should be able to get all the relevant settings.

2019-07-09_00h51_24

Could you please elaborate on what options you are missing? Or please send screenshots that contain all the Yotpo plugin settings as the screenshot provided only provides a partial view.

Thank you.

SlavicB commented 5 years ago

That's an issue with EE from what I see, we will address this in one of our upcoming releases, thank you for reporting this.

hobadams commented 5 years ago

Thank you.

Are you ok to drop me an email when this is resolved.

Thanks Hob Adams Senior Developer [image: Gene Commerce - specialist ecommerce agency] http://gene.co.uk/ [image: Magento Solutions Partner] [image: Magento 2 Solutions Partner] https://magento.com/ T: +44(0) 1273 030390 | 20 Middle Street, Brighton, BN1 1AL [image: Twitter Logo] https://twitter.com/gene_commerce [image: LinkedIn Logo] https://www.linkedin.com/company/gene-commerce gene.co.uk Registered Office: 20 Middle Street, Brighton, BN1 1AL. Registered in England and Wales No.08589522

On Tue, 16 Jul 2019 at 11:34, SlavicB notifications@github.com wrote:

That's an issue with EE from what I see, we will address this in one of our upcoming releases, thank you for reporting this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/YotpoLtd/magento2-module-yotpo-reviews/issues/164?email_source=notifications&email_token=ACI4AOJRMGZ2C5HAUTM5DJTP7WP3TA5CNFSM4H32LIVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2AN5JQ#issuecomment-511762086, or mute the thread https://github.com/notifications/unsubscribe-auth/ACI4AOJM22ZWDZ4CYKQBYS3P7WP3TANCNFSM4H32LIVA .

DanGlz commented 4 years ago

Hey @hobadams,

This bug has been fixed in the latest release (v2.9.2).

Let us know if there is any issue. Thanks.