search

YotpoLtd / magento2-module-yotpo-reviews

Open Software License 3.0
23 stars 38 forks source link

Added PHP 8 to version constraint #291

Closed peterjaap closed 2 years ago

peterjaap commented 2 years ago

LGTM!

$ vendor/bin/phpcs -p vendor/yotpo/magento2-module-yotpo-reviews --standard=vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 8.0 
................................................ 48 / 48 (100%)

Time: 1.54 secs; Memory: 14MB

$ vendor/bin/phpcs -p vendor/yotpo/magento2-module-yotpo-reviews --standard=vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 8.1
................................................ 48 / 48 (100%)

Time: 1.51 secs; Memory: 14MB
LiorGingi commented 2 years ago

Hi @peterjaap,

I've answered this matter in issue #293.

Hope it helps, Lior Gingihashvili.