Library cannot be loaded via composer

YotpoLtd / yotpo-php

A PHP interface to the YOTPO API

MIT License

11 stars 13 forks source link

Library cannot be loaded via composer #3

Open oadam opened 9 years ago

oadam commented 9 years ago

When I decided to use this library, I added it to my composer.json file and expected it to work out of the box. After painful hours of debugging, I re-read the README file and came to realise that the only way to install this library is to git clone it and run composer from within the cloned folder.

Ideally it would be great if the library could be installed via composer.
If not possible, could you at least add a bold statement at the start of the README saying that installation via composer is not supported ?

Thanks, Olivier

lsolesen commented 8 years ago

You can find it on packagist here: https://packagist.org/packages/yotpo/yotpo

oadam commented 8 years ago

It is on packagist but the package doesn't work if installed with composer. Last time I checked, Yotpo assumed its folder contained a vendor folder. The only way I managed to make it work was to download the directory from github, cd to it, and run composer install

lsolesen commented 8 years ago

Ah. Ok. I will try it out.

lsolesen commented 8 years ago

Hi @oadam I've created a pull request, which should fix this: https://github.com/YotpoLtd/yotpo-php/pull/5. Do you care to take it for a spin to see whether you like how it turned out. Then hopefully @vladshub will merge it in and tag a new version (which should probably be 0.0.3 which is not released yet https://github.com/YotpoLtd/yotpo-php/blob/master/src/Yotpo/Yotpo.php#L16)

oadam commented 8 years ago

I should be able to have a look at this tomorrow. Thanks !

mattmintun commented 5 years ago

3 years later - I'm here to say that @lsolesen edits make this repository actually work!