The TPRESTART syslog message relies on all cdb_sc_blkmod occurrences invoking the
TP_TRACE_HIST_MOD macro. One case in gvcst_expand_key.h was missed out. Now fixed.
The user-visible impact of this is that some L type of restarts in TP could
print a potentially incorrect "type:" field because the type was not set as part of
the current restart (but are using a leftover value of TREF(blkmod_fail_type) from a
prior restart in the same process).
In case a cdb_sc_blkmod happens in op_tcommit, it used to be classified as a
tp_blkmod_t_qread which is misleading since this is not the usual invocation of
"t_qread" before the TCOMMIT command. So make this a new type "tp_blkmod_op_tcommit".
This is now recognized by tp_restart() to decide whether to print unsubscripted
gvn or not in the TPRESTART syslog message. This would make the TPRESTART syslog
message more fine-grained in terms of the type of restart.
In tp_hist & tp_tend, the global variable TREF(tprestart_syslog_delta) was used in
various places. This is now speeded up by copying this into a local variable.
Additionally, a check of "1 != n_blkmods" is now made debug-only. The if block would
have always been skipped for a pro build.
The TPRESTART syslog message relies on all cdb_sc_blkmod occurrences invoking the TP_TRACE_HIST_MOD macro. One case in gvcst_expand_key.h was missed out. Now fixed. The user-visible impact of this is that some L type of restarts in TP could print a potentially incorrect "type:" field because the type was not set as part of the current restart (but are using a leftover value of TREF(blkmod_fail_type) from a prior restart in the same process).
In case a cdb_sc_blkmod happens in op_tcommit, it used to be classified as a tp_blkmod_t_qread which is misleading since this is not the usual invocation of "t_qread" before the TCOMMIT command. So make this a new type "tp_blkmod_op_tcommit". This is now recognized by tp_restart() to decide whether to print unsubscripted gvn or not in the TPRESTART syslog message. This would make the TPRESTART syslog message more fine-grained in terms of the type of restart.
In tp_hist & tp_tend, the global variable TREF(tprestart_syslog_delta) was used in various places. This is now speeded up by copying this into a local variable. Additionally, a check of "1 != n_blkmods" is now made debug-only. The if block would have always been skipped for a pro build.
Comments in tp_restart have been enhanced.