search

YottaDB / YDB

Mirrored from https://gitlab.com/YottaDB/DB/YDB
Other
76 stars 37 forks source link

Merge GT.M V6.3-005 into YottaDB mainline #317

Closed nars1 closed 6 years ago

nars1 commented 6 years ago

I addressed all your comments. If you know of any specific modules that need "else" or other coding standards issues fixed let me know and I can do it.

estess commented 6 years ago

I didn't keep track of them so I guess we'll fix them as we run into them again.

On 08/01/2018 02:24 PM, Narayanan Iyer wrote:

I addressed all your comments. If you know of any specific modules that need "else" or other coding standards issues fixed let me know and I can do it.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/YottaDB/YottaDB/pull/317#issuecomment-409674146, or mute the thread https://github.com/notifications/unsubscribe-auth/Abx8ONqVq5lfyodNmGZ3HfOPlWcq4zHVks5uMfJZgaJpZM4Vbhdr.

estess commented 6 years ago

I would like to remove it as I think it is dangerous as it sits in case someone looks it over and figures it can deal with a newly added error or something. I'm really curious as to the origin of that addition and what it allegedly solved. Oh well.

Steve

On 08/01/2018 04:08 PM, Narayanan Iyer wrote:

@nars1 commented on this pull request.

In sr_unix/gtm_init_env.c https://github.com/YottaDB/YottaDB/pull/317#discussion_r207014942:

GBLREF stack_frame *frame_pointer;

void gtm_init_env(rhdtyp base_addr, unsigned char transfer_addr) { assert(CURRENT_RHEAD_ADR(base_addr) == base_addr);

  • ESTABLISH(mdb_condition_handler);

I don't see any way to trigger an error inside gtm_init_env.c. The only error possibilities are STACKCRIT and STACKOFLOW. And because this function is invoked only when the process starts, the M stack is empty at that time AND the M-stack size is a minimum of 25KiB, there is no way of getting a STACKCRIT error for the one or two frames that we allocate at startup. So not sure why this change was necessary. Maybe it was done as part of general cleanup. I don't see any way having the ESTABLISH/REVERT makes any difference because of this. Given this, would you like removing this or keep it as is? My inclination is to leave it as is.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/YottaDB/YottaDB/pull/317#discussion_r207014942, or mute the thread https://github.com/notifications/unsubscribe-auth/Abx8OE8VtXH5fzSllDao4jYhO7SG94g0ks5uMgq1gaJpZM4Vbhdr.