YouHaveTrouble / CommandWhitelist

You decide what commands players can use or tab complete on your server!
GNU General Public License v2.0
207 stars 22 forks source link

feat: add support to Folia #68

Closed Aitooor closed 1 year ago

Aitooor commented 1 year ago

Testet and working: https://imgur.com/a/ru6zQyW

YouHaveTrouble commented 1 year ago

Okay, a question first. At first glance I don't see any changes made in the folia module besides adding folia-supported tag in plugin.yml, is the module necessary at all or can folia-supported be just added to bukkit module? Maybe I'm missing something?

Aitooor commented 1 year ago

Okay, a question first. At first glance I don't see any changes made in the folia module besides adding folia-supported tag in plugin.yml, is the module necessary at all or can folia-supported be just added to bukkit module? Maybe I'm missing something?

Changed Server#scheduler to Server#asyncScheduler

YouHaveTrouble commented 1 year ago

If that is the only change then I would consider just swapping the scheduler to a CompletableFuture for config reload. It's way smaller change and should work perfectly fine on both bukkit and folia

Aitooor commented 1 year ago

If that is the only change then I would consider just swapping the scheduler to a CompletableFuture for config reload. It's way smaller change and should work perfectly fine on both bukkit and folia

Suree no problem, thanks for considering me

Aitooor commented 1 year ago

You can close this PR if you want then 😄

YouHaveTrouble commented 1 year ago

Do you want to change it to the CompletableFuture, or should I?

YouHaveTrouble commented 1 year ago

Pushed the change to completable future and folia compatible in plugin.yml. Thanks for figuring out what needed to be changed!