Closed Aitooor closed 1 year ago
Okay, a question first. At first glance I don't see any changes made in the folia module besides adding folia-supported tag in plugin.yml, is the module necessary at all or can folia-supported be just added to bukkit module? Maybe I'm missing something?
Okay, a question first. At first glance I don't see any changes made in the folia module besides adding folia-supported tag in plugin.yml, is the module necessary at all or can folia-supported be just added to bukkit module? Maybe I'm missing something?
Changed Server#scheduler to Server#asyncScheduler
If that is the only change then I would consider just swapping the scheduler to a CompletableFuture for config reload. It's way smaller change and should work perfectly fine on both bukkit and folia
If that is the only change then I would consider just swapping the scheduler to a CompletableFuture for config reload. It's way smaller change and should work perfectly fine on both bukkit and folia
Suree no problem, thanks for considering me
You can close this PR if you want then 😄
Do you want to change it to the CompletableFuture, or should I?
Pushed the change to completable future and folia compatible in plugin.yml. Thanks for figuring out what needed to be changed!
Testet and working: https://imgur.com/a/ru6zQyW