search

YouHaveTrouble / CommandWhitelist

You decide what commands players can use or tab complete on your server!
GNU General Public License v2.0
207 stars 22 forks source link

Command lock does not work properly in 1.20.4 #87

Closed ChrisTVH closed 4 months ago

ChrisTVH commented 4 months ago

When I use it with ProtocolLib, it simply does not work, even though I have added the commands to the list, the autocomplete of the commands does not appear that is fine, but the commands do execute.

When I use it without ProtocolLib, the commands are not executed, not even the commands that are in the list are executed, sometimes they are executed but the little message that you put by default when the commands are blocked appears.

The steps to reproduce are simple, first have ProtocolLib 5.2.0 or higher, have this version of the server: image

Just in case, my list of plugins: image

If more information is required I will be happy to provide it, as additional information, I have this plugin on both my proxy and backend servers. As to whether any errors appear in the console, I have not seen any. Versions used: CommandWhitelist-Bukkit-2.8.2 and CommandWhitelist-Velocity-2.8.1.

YouHaveTrouble commented 4 months ago

Yes, this is exactly why I say it every time, if you don't need to enable it, don't enable it. it's not "better" to do this on packet level. I will have to look into removing protocollib feature entirely as plugins that needed it either died or now allow to create aliases in commands.yml

ChrisTVH commented 4 months ago

Yes, this is exactly why I say it every time, if you don't need to enable it, don't enable it. it's not "better" to do this on packet level. I will have to look into removing protocollib feature entirely as plugins that needed it either died or now allow to create aliases in commands.yml

You mean this is happening because of that? I have two plugins that use ProtocolLib, Lib's Disguises and ItemsAdder.

But otherwise it's as you say, no one else uses it.

YouHaveTrouble commented 4 months ago

I mean it in CW's case. It's not "better" to handle commands on the packet level. Just disable it in the config unless it's absolutely necessary.

ChrisTVH commented 4 months ago

I mean it in CW's case. It's not "better" to handle commands on the packet level. Just disable it in the config unless it's absolutely necessary.

Yep, it just doesn't work either way :/

YouHaveTrouble commented 4 months ago

I'm closing this with a resolution that it's an issue specific to your setup. It's literally not possible for cw to block tab completion, but not execution. There is only one list for both features. One working and second not working can only mean something else is interfering.