YouROK / TorrServe

GNU General Public License v3.0
445 stars 51 forks source link

Implicit 80/443 port setting #82

Closed lufton closed 1 year ago

lufton commented 1 year ago

Could you please consider change the logic of parsing server URL so when it explicitly set to use http or https scheme, then implicitly set ports to 80 or 443 respectively and if it just an IP address, then set port to 8090 (if not set explicitly). I'm using reverse proxy and port forwarding 443 -> 8090, so right now if I just set server URL to https://ts.mydomain.com the app automatically set the port to 8090, even though I didn't told that explicitly. The workaround is to explicitly set port to 443: https://ts.mydomain.com:443, but that is not really convenient.

tsynik commented 1 year ago

Could you please consider change the logic of parsing server URL so when it explicitly set to use http or https scheme, then implicitly set ports to 80 or 443 respectively and if it just an IP address, then set port to 8090 (if not set explicitly). I'm using reverse proxy and port forwarding 443 -> 8090, so right now if I just set server URL to https://ts.mydomain.com the app automatically set the port to 8090, even though I didn't told that explicitly. The workaround is to explicitly set port to 443: https://ts.mydomain.com:443, but that is not really convenient.

torrserve is not web browser, and torrserver web port must be defined explicitly. user can use http scheme on 443 port and https scheme on 80. So, you need to always define working scheme and port for torrserver