YouTube-Enhancer / extension

A browser extension to enhance YouTube
MIT License
149 stars 13 forks source link

Playback speed control way too sensitive on trackpad #698

Open theosib opened 5 days ago

theosib commented 5 days ago

Describe the bug I like how we can control the playback speed using the control key and the mouse wheel. But when trying to do the same on a trackpad (two finger scroll on my Mac), the control is basically impossible to use, because the tiniest amount of scroll results in a wild speed change.

To Reproduce

  1. Use a Mac laptop
  2. Hold control
  3. Use two-finger scroll gesture

Expected behavior Playback speed should change smoothly and not jump wildly.

Desktop (please complete the following information):

Additional context It may also be necessary to include an alternate input method. For example, in the control panel for this extension, there is a Playback speed section that says, "Speed variation when rotating the mouse wheel or when clicking the speed buttons “-” and “+”: 0.1", but there are no actual “-” and “+” speed buttons anywhere.

VampireChicken12 commented 5 days ago

@theosib Thank you for making this issue. We will look into to it as soon as possible. I suspect this is an issue on any laptop trackpad because of the sensitive nature of them.

VampireChicken12 commented 5 days ago

when clicking the speed buttons “-” and “+”: 0.1", but there are no actual “-” and “+” speed buttons anywhere. They need to be enabled, The extension doesn't come with opinionated defaults. Once the playback speed buttons are enabled they will show on the left side of the player controls by default. @theosib

VampireChicken12 commented 5 days ago

We have considered adding an option to load a default configuration that has some stuff enabled by default. But as of right now there is no planned release of that.

VampireChicken12 commented 4 days ago

@theosib I started working on fixing this issue. I am unable to test it myself because I don't have a laptop. I'm going to have @livingflore test it when he is free. Once I fix it, I'll work on a few more fixes that need to be done and then release a new version of the extension.