YouTubeHDR / hdr_metadata

159 stars 38 forks source link

Please check if SDR LUTs are actually used #7

Open zmarty opened 7 years ago

zmarty commented 7 years ago

Video without LUT: https://youtu.be/V9Ipg2jA9cg?t=25s Video with LUT: https://youtu.be/CR5v7oHBA74?t=25s

The MKV I uploaded for the second video contains an attachment named sdr.cube.

Can you confirm the sdr.cube LUT file is actually being used?

The problem is I don't see any difference between the videos. The LUT I uploaded should fix the burnt orange skin tones of the first video but does not.

zmarty commented 7 years ago

Here are the command lines I used to add the cube: --attachment-mime-type application/x-cube ^ --attach-file sdr.cube ^

And here is what MediaInfo says: MediaInfo

stevenrobertson commented 7 years ago

Thanks for the report. There is a bug here that's emerged since the HDR launch, and we're looking into it.

zmarty commented 7 years ago

Is this solved? Thanks!

zmarty commented 7 years ago

I asked around and other people uploading HDR video are experiencing the same issue. Are we doing this wrong or it's still not fixed yet?

morphinapg commented 4 years ago

I am fairly certain LUTs are still not working. I've put a lot of work into making sure my HDR videos look as good as they can be in SDR, but youtube's just ignoring it. Please fix this.

Note, this is not really an issue with this metadata tool. It attaches the LUT correctly, and this can also be accomplished in MKVToolnix (as well as the other metadata stuff) but it's an issue on the youtube server end.

EDIT: renaming my LUTs with lowercase file extensions instead of uppercase fixed my problem. That's pretty disappointing, although it can't be the same issue OP was having 3 years ago. Perhaps they fixed that but still had poor code for checking whether a LUT was attached.

MuscularPuky commented 1 month ago

I am fairly certain LUTs are still not working. I've put a lot of work into making sure my HDR videos look as good as they can be in SDR, but youtube's just ignoring it. Please fix this.

Note, this is not really an issue with this metadata tool. It attaches the LUT correctly, and this can also be accomplished in MKVToolnix (as well as the other metadata stuff) but it's an issue on the youtube server end.

EDIT: renaming my LUTs with lowercase file extensions instead of uppercase fixed my problem. That's pretty disappointing, although it can't be the same issue OP was having 3 years ago. Perhaps they fixed that but still had poor code for checking whether a LUT was attached.

mine is lowercase but same problem. youtube SERVER ignores lut, while metadata is fine

morphinapg commented 1 month ago

I am fairly certain LUTs are still not working. I've put a lot of work into making sure my HDR videos look as good as they can be in SDR, but youtube's just ignoring it. Please fix this. Note, this is not really an issue with this metadata tool. It attaches the LUT correctly, and this can also be accomplished in MKVToolnix (as well as the other metadata stuff) but it's an issue on the youtube server end. EDIT: renaming my LUTs with lowercase file extensions instead of uppercase fixed my problem. That's pretty disappointing, although it can't be the same issue OP was having 3 years ago. Perhaps they fixed that but still had poor code for checking whether a LUT was attached.

mine is lowercase but same problem. youtube SERVER ignores lut, while metadata is fine

Make sure the LUT is 32pt. I tried using higher quality LUTs but it wasn't working.

That being said, recently the server had been processing my LUTs incorrectly, swapping red and blue channels, but I've been working with youtube support to get that fixed. Not sure if others are having that issue.

MuscularPuky commented 1 month ago

I am fairly certain LUTs are still not working. I've put a lot of work into making sure my HDR videos look as good as they can be in SDR, but youtube's just ignoring it. Please fix this. Note, this is not really an issue with this metadata tool. It attaches the LUT correctly, and this can also be accomplished in MKVToolnix (as well as the other metadata stuff) but it's an issue on the youtube server end. EDIT: renaming my LUTs with lowercase file extensions instead of uppercase fixed my problem. That's pretty disappointing, although it can't be the same issue OP was having 3 years ago. Perhaps they fixed that but still had poor code for checking whether a LUT was attached.

mine is lowercase but same problem. youtube SERVER ignores lut, while metadata is fine

Make sure the LUT is 32pt. I tried using higher quality LUTs but it wasn't working.

That being said, recently the server had been processing my LUTs incorrectly, swapping red and blue channels, but I've been working with youtube support to get that fixed. Not sure if others are having that issue.

Premiere Pro exports 16 only. ah then

...would you tell me "It's 32 and below, not exactly 32"...?

morphinapg commented 1 month ago

I am fairly certain LUTs are still not working. I've put a lot of work into making sure my HDR videos look as good as they can be in SDR, but youtube's just ignoring it. Please fix this. Note, this is not really an issue with this metadata tool. It attaches the LUT correctly, and this can also be accomplished in MKVToolnix (as well as the other metadata stuff) but it's an issue on the youtube server end. EDIT: renaming my LUTs with lowercase file extensions instead of uppercase fixed my problem. That's pretty disappointing, although it can't be the same issue OP was having 3 years ago. Perhaps they fixed that but still had poor code for checking whether a LUT was attached.

mine is lowercase but same problem. youtube SERVER ignores lut, while metadata is fine

Make sure the LUT is 32pt. I tried using higher quality LUTs but it wasn't working. That being said, recently the server had been processing my LUTs incorrectly, swapping red and blue channels, but I've been working with youtube support to get that fixed. Not sure if others are having that issue.

Premiere Pro exports 16 only. ah then

...would you tell me "It's 32 and below, not exactly 32"...?

That I'm not sure, but open an image in photoshop, add an adjustment layer for Color Lookup, load the LUT in there, and then go to File -> Export -> Color Lookup Tables and you'll be able to convert it to 32 point that way

MuscularPuky commented 1 month ago

I am fairly certain LUTs are still not working. I've put a lot of work into making sure my HDR videos look as good as they can be in SDR, but youtube's just ignoring it. Please fix this. Note, this is not really an issue with this metadata tool. It attaches the LUT correctly, and this can also be accomplished in MKVToolnix (as well as the other metadata stuff) but it's an issue on the youtube server end. EDIT: renaming my LUTs with lowercase file extensions instead of uppercase fixed my problem. That's pretty disappointing, although it can't be the same issue OP was having 3 years ago. Perhaps they fixed that but still had poor code for checking whether a LUT was attached.

mine is lowercase but same problem. youtube SERVER ignores lut, while metadata is fine

Make sure the LUT is 32pt. I tried using higher quality LUTs but it wasn't working. That being said, recently the server had been processing my LUTs incorrectly, swapping red and blue channels, but I've been working with youtube support to get that fixed. Not sure if others are having that issue.

Premiere Pro exports 16 only. ah then ...would you tell me "It's 32 and below, not exactly 32"...?

That I'm not sure, but open an image in photoshop, add an adjustment layer for Color Lookup, load the LUT in there, and then go to File -> Export -> Color Lookup Tables and you'll be able to convert it to 32 point that way

oh that's interesting method... I suspected Hybird Log Gamma before you reply so published 4 case files. (PQ/HLG, 16/32) I hope youtube process mine as soon as possible within 1h

MuscularPuky commented 1 month ago

interestingly Windows 11 native player also recognizes LUTs. and I just found out youtube does not use LUT in HLG video ANYMORE. so my LUT was ignored

I tested 2 case files—1 is with Premiere Pro to Photoshop converted LUT, another is with adjusted only in Photoshop LUT

Windows 11 PQ with ANY LUT: ignored HLG with ANY LUT: works well

youtube PQ with converted LUT: ignored HLG with converted LUT: HDR disabled. WHAT?? PQ with original LUT: ignored HLG with original LUT: converted to SDR by youtube. in HDR, the color is not perfect than PQ but still looks great

so youtube does not apply my LUTs in any case :( I'll wait their process more

morphinapg commented 1 month ago

interestingly Windows 11 native player also recognizes LUTs. and I just found out youtube does not use LUT in HLG video ANYMORE. so my LUT was ignored

I tested 2 case files—1 is with Premiere Pro to Photoshop converted LUT, another is with adjusted only in Photoshop LUT

Windows 11 PQ with ANY LUT: ignored HLG with ANY LUT: works well

youtube PQ with converted LUT: ignored HLG with converted LUT: HDR disabled. WHAT?? PQ with original LUT: ignored HLG with original LUT: converted to SDR by youtube. in HDR, the color is not perfect than PQ but still looks great

so youtube does not apply my LUTs in any case :( I'll wait their process more

Are you sure your PQ metadata is correct? BT2020 primaries and matrix, and ST2084 transfer fuction? Here's an example of what the mediainfo looks like for one of my videos that gets processed correctly:

image

Note I've had videos process successfully without the MaxCLL/MaxFALL metadata but it's still a good idea to include those if you know the appropriate values.

MuscularPuky commented 1 month ago

interestingly Windows 11 native player also recognizes LUTs. and I just found out youtube does not use LUT in HLG video ANYMORE. so my LUT was ignored I tested 2 case files—1 is with Premiere Pro to Photoshop converted LUT, another is with adjusted only in Photoshop LUT Windows 11 PQ with ANY LUT: ignored HLG with ANY LUT: works well youtube PQ with converted LUT: ignored HLG with converted LUT: HDR disabled. WHAT?? PQ with original LUT: ignored HLG with original LUT: converted to SDR by youtube. in HDR, the color is not perfect than PQ but still looks great so youtube does not apply my LUTs in any case :( I'll wait their process more

Are you sure your PQ metadata is correct? BT2020 primaries and matrix, and ST2084 transfer fuction? Here's an example of what the mediainfo looks like for one of my videos that gets processed correctly:

image

Note I've had videos process successfully without the MaxCLL/MaxFALL metadata but it's still a good idea to include those if you know the appropriate values.

yes mine PQ video has BT.2020+ST.2084, and HLG video has arib-std-b67 as I know MaxCLL/MaxFALL data is for HDR10 so if the video is just only HDR, not HDR10 then we can ignore those if HDR video has no MaxCLL/MaxFALL, I think they'll treat as 1000 but not sure perhaps youtube LUT processing nedds more time... maybe... ah.

one thing I suspect: if youtube considered the LUT as nonsence—would rather spoil the video, invalid data, incompatible, etc, could they ignore the LUT??

morphinapg commented 1 month ago

interestingly Windows 11 native player also recognizes LUTs. and I just found out youtube does not use LUT in HLG video ANYMORE. so my LUT was ignored I tested 2 case files—1 is with Premiere Pro to Photoshop converted LUT, another is with adjusted only in Photoshop LUT Windows 11 PQ with ANY LUT: ignored HLG with ANY LUT: works well youtube PQ with converted LUT: ignored HLG with converted LUT: HDR disabled. WHAT?? PQ with original LUT: ignored HLG with original LUT: converted to SDR by youtube. in HDR, the color is not perfect than PQ but still looks great so youtube does not apply my LUTs in any case :( I'll wait their process more

Are you sure your PQ metadata is correct? BT2020 primaries and matrix, and ST2084 transfer fuction? Here's an example of what the mediainfo looks like for one of my videos that gets processed correctly: image Note I've had videos process successfully without the MaxCLL/MaxFALL metadata but it's still a good idea to include those if you know the appropriate values.

yes mine PQ video has BT.2020+ST.2084, and HLG video has arib-std-b67 as I know MaxCLL/MaxFALL data is for HDR10 so if the video is just only HDR, not HDR10 then we can ignore those if HDR video has no MaxCLL/MaxFALL, I think they'll treat as 1000 but not sure perhaps youtube LUT processing nedds more time... maybe... ah.

one thing I suspect: if youtube considered the LUT as nonsence—would rather spoil the video, invalid data, incompatible, etc, could they ignore the LUT??

I think in my experience when I had a LUT formatted in ways they didn't like (like the 64 size one I started with, or the .CUBE in caps) then I believe it interpreted my videos as not being HDR at all, and showing the raw unprocessed signal as if it was being interpreted as a SDR-encoded file. So super washed out, wrong contrast and colors, etc. But this was years ago so I'm not sure if they do things differently now.

But currently as long as I upload with correct primaries/transform/matrix values, and a 32 point .cube LUT with all lowercase letters (I also do no spaces just in case) then it seems to work fine. Yes it can take longer to process, but the SDR portion usually processes first and matches the LUT when it does.

morphinapg commented 3 weeks ago

interestingly Windows 11 native player also recognizes LUTs. and I just found out youtube does not use LUT in HLG video ANYMORE. so my LUT was ignored I tested 2 case files—1 is with Premiere Pro to Photoshop converted LUT, another is with adjusted only in Photoshop LUT Windows 11 PQ with ANY LUT: ignored HLG with ANY LUT: works well youtube PQ with converted LUT: ignored HLG with converted LUT: HDR disabled. WHAT?? PQ with original LUT: ignored HLG with original LUT: converted to SDR by youtube. in HDR, the color is not perfect than PQ but still looks great so youtube does not apply my LUTs in any case :( I'll wait their process more

Are you sure your PQ metadata is correct? BT2020 primaries and matrix, and ST2084 transfer fuction? Here's an example of what the mediainfo looks like for one of my videos that gets processed correctly: image Note I've had videos process successfully without the MaxCLL/MaxFALL metadata but it's still a good idea to include those if you know the appropriate values.

yes mine PQ video has BT.2020+ST.2084, and HLG video has arib-std-b67 as I know MaxCLL/MaxFALL data is for HDR10 so if the video is just only HDR, not HDR10 then we can ignore those if HDR video has no MaxCLL/MaxFALL, I think they'll treat as 1000 but not sure perhaps youtube LUT processing nedds more time... maybe... ah.

one thing I suspect: if youtube considered the LUT as nonsence—would rather spoil the video, invalid data, incompatible, etc, could they ignore the LUT??

I thought of something. Have you made sure that MIME type on the attachment is set to "application/x-cube"? I don't know whether it's strictly necessary, but the original documentation does list to use that, and I always have.