Youda008 / DoomRunner

Preset-oriented graphical launcher of various ported Doom engines (an alternative to ZDL)
GNU General Public License v3.0
204 stars 13 forks source link

[Bug] DoomRunner 1.7.2 concatenates -savedir value and save file name in -loadgame value #113

Closed bryanburke closed 11 months ago

bryanburke commented 12 months ago

When More options -> Alternative paths -> Save dir has a value, DoomRunner appends -savedir <savedir_value> to the GZDoom launch command as expected.

image

... -savedir "./foo" ...

However, when More options -> Launch mode -> Load saved game is selected and has a value, DoomRunner appends -loadgame <savedir_value>/<savefile_value> to the launch command, effectively concatenating the save directory and the save file name.

image

... -loadgame "./foo/save00.zds" -savedir "./foo" ...

This causes GZDoom 4.10.0 (I did not test earlier versions) to try to load a save game file at ./foo//./foo/save00.zds and thus crash with the error message:

Cannot find savegame ./foo//./foo/save00.zds

I believe the fix is for DoomRunner to provide only the save file name as the -loadgame value:

... -loadgame "save00.zds" -savedir "./foo" ...

Note that I did not test older GZDoom versions, so I do not know if this bug is a result of a change in GZDoom behavior.

Thanks for your time!

Youda008 commented 11 months ago

Thanks for reporting! This should be easy to fix. I was just about to release a new version with bugfixes yesterday, but luckily for us both i postponed it, so i can include this in it. Laziness saved me once again 😁

Youda008 commented 11 months ago

Should be fixed in the recently released 1.7.3.