search

Youda008 / DoomRunner

Preset-oriented graphical launcher of various ported Doom engines (an alternative to ZDL)
GNU General Public License v3.0
241 stars 18 forks source link

[Bug] "Cannot read version value" error #142

Closed NightFright2k19 closed 9 months ago

NightFright2k19 commented 10 months ago

With latest release, I get an errors.txt in my DoomRunner dir, stating the following:

[2024-01-16T15:05:51] [FAILURE] ExeReader: Cannot read version value, VerQueryValue("\StringFileInfo\040904e4\FileDescription") returned 0x2a429fd5abc,0

This already happened with dev builds and I hoped it would disappear with the final v1.8.2 release, but it's still a thing.

Used build: Static, Win x64

Youda008 commented 10 months ago

Damn, i forgot to log what file name it is. Can you try to run DoomRunner.exe from command line if it doesn't print any more info?

Anyway this is not a serious problem, it just says that one of the exe files that you added as Doom engine has an invalid version info inside itself. But we don't know which one.

NightFright2k19 commented 10 months ago

Well, I mostly use Woof! dev builds (those probably don't have version numbers), so it's probably that. I thought the error was related to DoomRunner.exe itself. Maybe just mute that warning or something? I mean, in the end it's without consequence, but I'm only getting that since a few weeks.

Otherwise: With "command line", you mean the Windows Terminal, I guess?

Youda008 commented 10 months ago

I just didn't think that this particular case of exe version info is possible, i thought it is a sign of the version info being corrupted, so i rather included a silent error report. I can remove it of course. But i don't think its worth making a new release just for this one problem.

"command line" or "command prompt" or "Windows terminal" or "Windows console" or "cmd.exe", they are all the same thing. Just not "PowerShell", that's something different.

NightFright2k19 commented 10 months ago

I'd say remove the warning and it'll be in the next official release. For me it's OK, I can build the launcher via tools if I need this change sooner.

Youda008 commented 10 months ago

I commited a change that will log the problematic file name to stdout, so if you run DoomRunner.exe from command line, you should be able to see which file doesn't have what. But you'll probably have to delete file_info_cache.json before that.