search

Youda008 / DoomRunner

Preset-oriented graphical launcher of various ported Doom engines (an alternative to ZDL)
GNU General Public License v3.0
205 stars 13 forks source link

Add .desktop file for Linux #65

Closed poperigby closed 1 year ago

Youda008 commented 1 year ago

Ok i have no idea what this does, so i trust you that it's correct.

poperigby commented 1 year ago

Ok i have no idea what this does, so i trust you that it's correct.

Thanks lol. It's basically the same think as a start menu entry on Windows.

Youda008 commented 1 year ago

@poperigby I have a question regarding the application icon. This file point to an icon in /usr/share/icons/doomrunner.ico but the project file doesn't specify any rule for installing the icon file into this location. How does the icon get there? Shouldn't that also be added?

poperigby commented 1 year ago

I was copying the icon file with the AUR package manifest. I think it's best to leave the PKGBUILD doing that job, but I'm open to changing it.

Youda008 commented 1 year ago

Ok, but shouldn't the desktop file then be also part of the AUR package? It looks strange that there is a file in my repository that points to something that is not installed. I think all the install rules (where to install executable, icon, .desktop file) should be together in a single repository and not be split between two.

mbugni commented 1 year ago

It could be useful to have a common template (application name, description, etc) for every Linux distribution channel, since a standard exists. I suggest to put Linux desktop files (.desktop, icons etc) in one place, for example Resources/XDG. Maintainers will take care to pick them from sources and to put them in the right place with the right name. If patches are needed, they can be applied during packaging process.

Icon names, in desktop entries, can be relative (no path, no extension), see [1]. I already provided a full icon set (see [2]). We can follow Flatpak recommendations [3], that are fine for modern desktops:

Applications must provide application icons in at least 64×64px and 128×128px sizes. Application icons should either be included as scalable SVGs or high-resolution PNGs

[1] https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html [2] https://github.com/Youda008/DoomRunner/issues/108 [3] https://github.com/flathub/flathub/wiki/App-Requirements

Youda008 commented 12 months ago

Alright. I have created a directory for OS-specific files to be installed and moved the .desktop file and png icon files there. Package maintainers will need to patch those if needed and then install them into proper directories.