Youda008 / DoomRunner

Preset-oriented graphical launcher of various ported Doom engines (an alternative to ZDL)
GNU General Public License v3.0
204 stars 13 forks source link

Hyperlink in "Update available" dialog box needs new color code #92

Closed Berzasperd closed 1 year ago

Berzasperd commented 1 year ago

I feel bad for not thinking about this before, but now that the update checker has the dark theme colors, it's hyperlink needs the same code that fixes the colors for the About dialog hyperlinks.

doomrunner_updatescreen

I was looking around the source code trying to see if it was something that could be copy and pasted over, but it is a little bit over my head for right now. The closest thing I found to something related to the issue was these two lines here.

https://github.com/Youda008/DoomRunner/blob/698a2831cb3c43e4e425192a14d95621f97a9431/Sources/UpdateChecker.cpp#L35 https://github.com/Youda008/DoomRunner/blob/698a2831cb3c43e4e425192a14d95621f97a9431/Sources/UpdateChecker.cpp#L36

This was based on what you had said before, about how each hyperlink was being generated with that specific code and that it would have to be overridden for each one to fix it. Hopefully I'm not just sending you on a wild goose chase with that. Either way, this is a tiny issue that can be fixed whenever is convenient for you. If I have some spare time, I might try to figure out compiling new code and/or making a pull request.

Youda008 commented 1 year ago

fixed