search

YoungMaker / iORC

iORC - Organized Roleplay Creator
3 stars 0 forks source link

Character page does not refresh when creating a new character #70

Closed YoungMaker closed 6 years ago

YoungMaker commented 6 years ago

The snackbar popup comes up but the character list did not refresh. Tested under the latest build in the skillsList branch

hwilling commented 6 years ago

character list refreshed both times that I tested this

hwilling commented 6 years ago

issue was most likely caused by snackbar being created on button press to finish creating character instead of being called when the creation mutation returns successful

YoungMaker commented 6 years ago

This issue is occurring on my phone using 4g. Might just be long connection times. This is not on the caching branch it is on a skillsList build.

hwilling commented 6 years ago

yeah i tested it on skillsList it's most likely due to a delayed connection combined with when the snackbar has been created, I moved the location of the snackbar creation and am committing it now

YoungMaker commented 6 years ago

Try on your phone on 4g?

hwilling commented 6 years ago

okay I will then

hwilling commented 6 years ago

Yes there was a little bit of a delay

hwilling commented 6 years ago

It seems fine with this updated creation location though, the only thing that could cause a delay with the list refresh is if the query that gets the refreshed list takes time to return or does not return, however, it will only say that the character has been created if the character creation mutation returns as a success. Commit 0d3872e is where this is applied

hwilling commented 6 years ago

@YoungMaker is this good to close then?

YoungMaker commented 6 years ago

Confirmed. Closed in 0d3872e