YoungVision-eV / homepage-sveltekit

https://www.youngvision.org/
GNU General Public License v3.0
3 stars 0 forks source link

Use a visual regression testing platform #2

Open MrGreenTea opened 1 year ago

MrGreenTea commented 1 year ago

Right now we use playwright snapshots directly which works but does not allow approval of changes (or just by running pnpm run update-snapshots)

Some options are:

There might be more options which should be checked for pricing, features and ease-of-use

MrGreenTea commented 1 year ago

https://lost-pixel.com/

MrGreenTea commented 10 months ago

We could also just assign the design team when changes to the screenshots are detected. As we use gitstream already:

https://docs.gitstream.cm/automations/assign-reviewers-by-directory/

MrGreenTea commented 10 months ago

We could also just assign the design team when changes to the screenshots are detected. As we use gitstream already:

https://docs.gitstream.cm/automations/assign-reviewers-by-directory/

The comparison in the diff view kind off sucks for long screenshots like on mobile though...

MrGreenTea commented 10 months ago

We could also use browserstack to test on iOS devides. Currently we don't even test on simulated iPhone / WebKit

MrGreenTea commented 9 months ago

On first look two of them appeal to me the most:

With lost pixel though I can't find anything about their playwright integration as they seem to focus on storybook, ladle and next.js.

MrGreenTea commented 9 months ago

Lost pixels has some info about playwright here: https://docs.lost-pixel.com/user-docs/setup/project-configuration/modes#custom-shots

MrGreenTea commented 9 months ago

I like argos. It is easy to use and integrate with playwright.

Percy is very nice too and because they render the page on their side we also can get mobile and Safari screenshots without having to run the multiple browsers ourselves...

I think I prefer argos for now. It's integration with playwright makes it quite easy to use. Some integration to automatically add the project name to the screenshots for example would be nice.