search

YousefED / typescript-json-schema

Generate json-schema from your Typescript sources
BSD 3-Clause "New" or "Revised" License
3.17k stars 323 forks source link

Fix crashing on tslib not being installed (#483) #485

Closed BalaM314 closed 2 years ago

BalaM314 commented 2 years ago

The best commits are those that fix a crash by adding one character. Oops.

domoritz commented 2 years ago

Please fix the test run.

BalaM314 commented 2 years ago

It's because the dependency path-equal was updated, so yarn needs to update the yarn.lock file to specify a different version. Should I edit it manually? I don't know how to generate the SHA512 hash, its far shorter than the one I get from PowerShell.

domoritz commented 2 years ago

If you run yarn in the directory, it will update the lock file.

azrsh commented 2 years ago

@BalaM314 @domoritz Is this PR working? I am also having trouble with this issue and if it is not working I can take it over.

BalaM314 commented 2 years ago

The test is failing because I didn't update the lockfile. I just need to clone this repo and run yarn. Forgot this existed, will do in a few hours.

BalaM314 commented 2 years ago

image The issue seems to be with this command in the package.json

  "scripts": {
    "prepare": "tsc; yarn docs",

Changed it to tsc && yarn docs and it works.

domoritz commented 2 years ago

Thanks. Please update the pull request.

BalaM314 commented 2 years ago

Is this good?