search

YoussefHenna / expo-enode-link-sdk

An Expo Module integration for Enode's Link SDK
MIT License
8 stars 2 forks source link

Android: Missing 'success' resultcode #7

Closed bjornevik closed 9 months ago

bjornevik commented 9 months ago

Hi!

Thanks for this plugin!

When running on iOS I get a 'success' code once the onboarding has finished. On android I do not get any code once the onboarding has finished, but I still get other codes, like for instance the 'cancelledByUser' code.

I can't really see any reason why the current handling shouldn't work. Though to be fair I'm not particularly familiar with native android code or the SDKs for that matter.

YoussefHenna commented 9 months ago

Hey! Are you getting any other code in place of the expected 'success? Or just nothing?

bjornevik commented 9 months ago

  1. No code on success.

  2. When I close the window I get the expected cancelledByUser

YoussefHenna commented 9 months ago

Odd, we're currently in contact with the Enode team regarding another issue faced on android so we haven't been able to test the full flow on android yet. But I'll mention this and let you know when I hear back.

bjornevik commented 9 months ago

Seems like the problem was that I was passing a normal url (ex. https://google.com) instead of passing a myapp://-uri, to the redirectUri field in the API-call. Working now 😄

YoussefHenna commented 9 months ago

Glad you got it sorted!