search

YoussefHenna / expo-enode-link-sdk

An Expo Module integration for Enode's Link SDK
MIT License
7 stars 2 forks source link

Expo 50 SDK Compatibility #9

Closed bjornevik closed 7 months ago

bjornevik commented 7 months ago

closes #8

[!WARNING] I haven't actually tested this, eas-cli build didn't really want to play ball when I yarn add'ed my fork. (Seems like yarn is not happy with the prepare script in the git added module)

Changes made according to expo sdk 50 upgrade readme.

Seems like the recommended upgrade is to add a check for ANDROID_GRADLE_PLUGIN_VERSION, so I'm guessing it's backwards compatible with Expo SDK 49.

Relevant section:

  • If you maintain any Expo Modules:
    • For Android: update your library build.gradle to match the changes in this diff. You may also now remove the JVM target version configuration, as explained in this FYI page.
    • For iOS: update the platform deployment target field from '13.0' to '13.4', matching the changes in this diff.
bjornevik commented 7 months ago

I got around to spinning up a new expo project. Tried building for android with SDK 50 and 49, and both seem to work fine with these changes.

I don't personally see the need to test it on iOS as the change in deployment target shouldn't break anything for either build. But still @YoussefHenna if you'd like me to, I'll spin up a couple of iOS builds when I get time.

YoussefHenna commented 7 months ago

@bjornevik Sorry for the late response. But this looks great! I don't see the deployment target causing any issues, so this is good for now. We can circle back if we run into any issues down the line.

YoussefHenna commented 7 months ago

Thank you for your contribution!

YoussefHenna commented 7 months ago

Released in 0.4.0 🎉