Responsive Portfolio Project Pull Request

[YoutLone]

Porfolio website milestone : Module-1

In this project I :

• Added about me section using CSS flexbox and CSS grid
• Added work section using CSS flexbox and CSS grid

[YoutLone]

Hello David , I confused the last one of your review I need to change my index.html or not?

On Sat, 29 Apr 2023 at 12:11 AM David A. Tamayo @.***> wrote:

@.**** requested changes on this pull request. Hi @YoutLone https://github.com/YoutLone 🙋‍♂️,

Good job so far! You have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!

https://camo.githubusercontent.com/78087f8205c5736aa2d7d71fc32f3ec42ca7302de1c46e79464a18f3fba32dfb/68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f333151333645484a3743355a6f494d7737392f67697068792e676966 Top highlight 🎯

• The Pull Request follows the GitHub Flow ✅
• The PR title and description are professional and descriptive ✅
• Linters are working properly ✅

Suggested changes

• Check the comments under the review. ⬇

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

In style.css https://github.com/YoutLone/Portfolio/pull/2#discussion_r1180662680:

+.other-project-tags {

• display: flex;
• list-style-type: none; +}

• +.other-project-tag {

• font-family: "Inter", sans-serif;
• color: white;
• margin: 0 10px 20px 20px;
• font-size: 15px;
• background-color: #5c5c69;
• padding: 10px; +}

• Great job on creating the tags! 👍 However, to align with the Figma template, it is necessary to reduce the spacing between them and make the background transparent. This will not only make the tags look more visually appealing but also ensure that they are consistent with the overall design of the portfolio. By following these guidelines, the tags will be easier to read and will complement the design elements of the portfolio, ultimately enhancing the user experience.

Your design

[image: Screenshot from 2023-04-28 12-31-24] https://user-images.githubusercontent.com/105117832/235216051-7018df2c-b490-45c3-94c8-2e36f713048e.png

Figma

[image: Screenshot from 2023-04-28 12-31-45] https://user-images.githubusercontent.com/105117832/235216082-206b0e6d-2a4e-43ab-a0fe-b92b93f5765f.png

In style.css https://github.com/YoutLone/Portfolio/pull/2#discussion_r1180662723:

+.skills-wrapper {

• display: grid;
• grid-template-columns: 1fr;
• font-family: "inter", sans-serif;
• font-size: 32px;
• color: white;
• list-style-type: none; +}

• You've done an excellent job organizing the skills section of your portfolio 👍. However, it would be beneficial if you could adjust the spacing between the elements to align with the Figma template. This will ensure that the overall presentation looks more professional and visually appealing to viewers.

Your design

[image: Screenshot from 2023-04-28 12-31-01] https://user-images.githubusercontent.com/105117832/235215414-7d6cdfe0-a8e0-4389-8a11-984f8a6cabd8.png

Figma

[image: Screenshot from 2023-04-28 12-30-50] https://user-images.githubusercontent.com/105117832/235215459-2550bdac-a16b-471d-9164-20942eaccd77.png

In index.html https://github.com/YoutLone/Portfolio/pull/2#discussion_r1180665243:

• About Me

• Hello I’m a software developer! I can help you build a product ,
• feature or website Look through some of my work and experience! If you
• like what you see and have a project you need coded, don’t hesitate to
• contact me.
• Get My Resume

[IngDavidTM]

Hello David , I confused the last one of your review I need to change my index.html or not? …

Hi @YoutLone 👋, yes you need to change it