YoutLone / Portfolio

The Personal Portfolio Website is a project created to showcase my skills, experience, and accomplishments in a visually appealing and professional manner. This website serves as a comprehensive platform for presenting my work and introducing myself to potential employers, clients, and collaborators.
https://github.com/YoutLone/Portfolio
MIT License
4 stars 1 forks source link

Added Form Validation Pair-Programming with Htet Wai Yan #3

Closed YoutLone closed 1 year ago

YoutLone commented 1 year ago

Form Validation Portfolio

  1. added require attributes for each input fields
  2. added max length for name and textarea
  3. added the right type for each input fields
YoutLone commented 1 year ago

So can I use flexbox for desktop version.

On Tue, 2 May 2023 at 4:22 PM NTIHINDUKA ALPHA @.***> wrote:

@.**** requested changes on this pull request. Hello TeamπŸ™‹β€β™‚οΈ

Good job working on your first contact form. You have done the design to the best expectation and incredibly well. πŸ‘

You still need to implement few on the project but you are almost there!!! 🚢 :

TO HIGHLIGHT:

  • Your project is professional βœ…
  • Professional README file πŸ’―
  • Your PR is professional βœ…
  • Well-structured files βœ…

STATUS: Required Changes ♻️

[image: close] https://user-images.githubusercontent.com/99394374/210771148-619a4265-33b2-4e68-8901-6bb52693d6de.gif Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread or slack channel if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

HAPPY CODING AND GOOD LUCK 🀞 πŸ€

In style.css https://github.com/YoutLone/Portfolio/pull/3#discussion_r1182332903:

+.form-section {

  • margin-top: 70px;
  • width: 100%;
  • height: 750px;
  • background-color: white; +}
  • As the project requirements suggest, please try as much as possible to ensure you use flexbox to layout the elements of the contact form. I noticed that you used flex box in the desktop version which is very good approach πŸ‘. However, since our focus is on mobile version of the portifolio kindly ensure to use flexbox to layout the elements ☺️.

In index.html https://github.com/YoutLone/Portfolio/pull/3#discussion_r1182336233:

  • <img
  • class="footer-link-img"
  • src="images/Social Media.png"
  • alt="Social Media"/>

β€” Reply to this email directly, view it on GitHub https://github.com/YoutLone/Portfolio/pull/3#pullrequestreview-1408771941, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4IWYLANYQIFWUTRGQHKQ2DXEDKOVANCNFSM6AAAAAAXSZCSPU . You are receiving this because you authored the thread.Message ID: @.***>