Closed YoutLone closed 1 year ago
So can I use flexbox for desktop version.
On Tue, 2 May 2023 at 4:22 PM NTIHINDUKA ALPHA @.***> wrote:
@.**** requested changes on this pull request. Hello TeamπββοΈ
Good job working on your first contact form. You have done the design to the best expectation and incredibly well. π
You still need to implement few on the project but you are almost there!!! πΆ :
TO HIGHLIGHT:
- Your project is professional β
- Professional README file π―
- Your PR is professional β
- Well-structured files β
STATUS: Required Changes β»οΈ
[image: close] https://user-images.githubusercontent.com/99394374/210771148-619a4265-33b2-4e68-8901-6bb52693d6de.gif Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread or slack channel if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
HAPPY CODING AND GOOD LUCK π€ π
In style.css https://github.com/YoutLone/Portfolio/pull/3#discussion_r1182332903:
+.form-section {
- margin-top: 70px;
- width: 100%;
- height: 750px;
- background-color: white; +}
- As the project requirements suggest, please try as much as possible to ensure you use flexbox to layout the elements of the contact form. I noticed that you used flex box in the desktop version which is very good approach π. However, since our focus is on mobile version of the portifolio kindly ensure to use flexbox to layout the elements βΊοΈ.
In index.html https://github.com/YoutLone/Portfolio/pull/3#discussion_r1182336233:
- However much your design matches the Figma template design, you did not use proper semantics to layout the social icons of the footer. You should make sure that every social icon is attached to your personalized link. This is to ensure that the recruiters other portifolio visitors can easily contact you. Hint: You may need to use ul and li.
β Reply to this email directly, view it on GitHub https://github.com/YoutLone/Portfolio/pull/3#pullrequestreview-1408771941, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4IWYLANYQIFWUTRGQHKQ2DXEDKOVANCNFSM6AAAAAAXSZCSPU . You are receiving this because you authored the thread.Message ID: @.***>
Form Validation Portfolio