search

YouweGit / testing-suite

Collection of PHP code testing packages.
MIT License
11 stars 9 forks source link

Fix installation breaking for pimcore-project types #13

Closed Anve94 closed 1 year ago

Anve94 commented 1 year ago
Anve94 commented 1 year ago

FYI, the base of the ruleset templating came from a combination of 2 pimcore projects that already have the testing suite set up.

Ideally the added templates reference rulesets in a coding-standard-pimcore package, but for now the PR focuses on fixing the issue when the composer type is set to pimcore-project. I know there are some other people interested in working on the testing suite specifically for pimcore projects, so I think it's good to delegate some of the processes in regards to defining more balanced phpcs/phpmd rulesets and offloading it to a separate coding standard package to them.

Anve94 commented 1 year ago

Updated the PR to provide an example exclusion pattern. The patterns itself are project-specific, but I added an example pattern with a relative path to prevent phpcs from no longer sniffing when a typical exclusion like var/ is used, since the ddev containers are running in /var/www/html so var/ is excluded when attempting to exclude the var directory in the app root.