search

YozhikM / stylelint-a11y

Plugin for stylelint with a11y rules
MIT License
442 stars 30 forks source link

Update dependency tree for stylelint 14.0.1 #65

Open ronilaukkarinen opened 2 years ago

ronilaukkarinen commented 2 years ago

It seems dependencies are outdated. Please update.

npm ERR! Could not resolve dependency:
npm ERR! peer stylelint@"^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0" from stylelint-a11y@1.2.3
JustFly1984 commented 2 years ago

please update

ronilaukkarinen commented 2 years ago

It seems @YozhikM is not very active on GitHub nowadays. Please note that I have created a fork that works:

npm install @ronilaukkarinen/stylelint-a11y --save-dev
NishaJKulal commented 2 years ago

Even I am facing this issue.

thibaudcolas commented 2 years ago

For people following this discussion – there’s now talks of either adding some of those rules to Stylelint itself or creating another community plugin similar to stylelint-a11y here: https://github.com/stylelint/stylelint/issues/6212.

@ronilaukkarinen it’d be great to get your thoughts on this in particular!

ronilaukkarinen commented 2 years ago

Thanks for the ping @thibaudcolas, I'll add my two cents.

christian-weiss commented 9 months ago

Conclusion: stylelint-a11y is not moved to stylelint (core) and accessability will remain a plugin as decided here: https://github.com/stylelint/stylelint/issues/6212.

Meantime YozhikM/stylelint-a11y was forked multiple times.

As of now https://github.com/mechanical-ink/stylelint-a11y is not yet available as package on nodejs.com.

The following seams to be active (recent activity): @ronilaukkarinen/stylelint-a11y @double-great/stylelint-a11y Based on number of downloads, looks like community prefers https://www.npmjs.com/package/@ronilaukkarinen/stylelint-a11y

christian-weiss commented 9 months ago

/CLOSE

carlosjeurissen commented 9 months ago

@christian-weiss Thanks for your investigation! Both @ronilaukkarinen/stylelint-a11y and @double-great/stylelint-a11y seem incompatible with stylelint 16. Do you know if the one from @mechanical-ink is compatible with stylelint 16?

@YozhikM are you willing to add additional people to the npm package (https://www.npmjs.com/package/stylelint-a11y) so development can be taken over?

@ronilaukkarinen What are your thoughts on this going forward?

ronilaukkarinen commented 9 months ago

@ronilaukkarinen What are your thoughts on this going forward?

I can update it asap.

ronilaukkarinen commented 9 months ago

Updated. 16 support in v1.2.8.

carlosjeurissen commented 9 months ago

@ronilaukkarinen Thanks! When using it with stylelint 16, I still get the following error: Must use import to load ES Module: /stylelint@16.0.2/node_modules/stylelint/lib/utils/isStandardSyntaxRule.mjs

@mechanical-ink and @double-great can we agree on one single repository for maintaining this dependency going forward?

ronilaukkarinen commented 9 months ago

Hmm, somehow my tests didn't cause any errors. Going to take another look at it.

As for the other discussion, we're having the same in several issues. My take is here (tl;dr; I'm going to keep maintaining my own fork regardless).

ronilaukkarinen commented 9 months ago

Forced to revert back for the time being, see this. v1.2.9 out. Let's continue the discussion in their proper issues.