Ysurac / FlightAirMap

Open source project displaying live aircrafts, ships or trackers on 2D/3D map. Browse through the data based on a particular aircraft, airline, airport, tracker or vessel to search through the database or see extensive statistics. Can use ADS-B in SBS1 format (dump1090, Radarcape,...), VRS, VA (VATSIM, IVAO whazzup.txt, phpvms,...), ACARS (acarsdec, acarsdeco2), APRS, AIS as datasource.
https://www.flightairmap.com/
GNU Affero General Public License v3.0
516 stars 157 forks source link

List of minor bugs, missings or inexplicit behavior 2 #359

Closed TomMuc1 closed 6 years ago

TomMuc1 commented 6 years ago

3d model for HARBIN C-99 (E145) with BMI logo is always displayed in muuuch bigger size than all other aircraft models

bildschirmfoto 2017-10-05 um 21 24 46
Ysurac commented 6 years ago

Fixed when you run scripts/update_db.php.

TomMuc1 commented 6 years ago

works :)

small map window in lower rirgt corner does not zoom to aircraft position and does not follow selected aircraft -> nearly zero orientation in 3d mode for user when watching a selected aircraft.

TomMuc1 commented 6 years ago

3d model for twin engine business jet does not sit correctly on path - see pix

bildschirmfoto 2017-10-05 um 22 15 21

same here

bildschirmfoto 2017-10-05 um 22 48 19
Ysurac commented 6 years ago

minimap fixed

TomMuc1 commented 6 years ago

wow awesome - and how fast you are even with not sooo trivial things like that!!! the zoom level now is a little high. is there a variable and in which file i can manipulate this on my own. and then when i found the sweet spot give you the number i used?

Ysurac commented 6 years ago

in js/cesium-minimap.js line 83

TomMuc1 commented 6 years ago

whatever numbers i apply here(line 84) the zoom in minimap when aircraft is selected does not change

pos.height = Math.max(Math.min(pos.height,2200000) * 2, 2000);
TomMuc1 commented 6 years ago

the way 'sun shadow' is rendered is not nice nor in any way realistic

bildschirmfoto 2017-10-06 um 14 30 00

bildschirmfoto 2017-10-06 um 14 29 36

Ysurac commented 6 years ago

Again I don't see problem with sun shadow here. It's realistic for me. You can don't like sun shadow but it's another story.

TomMuc1 commented 6 years ago

ok - then we call it 'i don't like this way of sun shadow' :)

TomMuc1 commented 6 years ago

but what about the mini map zoom above? i tried to alter the three numbers in line 84 since found no number in line 83 - but this did not change the zoom level in mini-map ...

Ysurac commented 6 years ago

This change the height of the "camera", so it's really the "zoom" level.

TomMuc1 commented 6 years ago

ah - ok - and is there an easy option to hard code a different zoom level? as the map now looks a little unsharp and moreover shows too small area to really know where you are. it is really great that this mini map center follows the aircraft - but if it would show say 200 x 200 km i think about this the sweet spot were to have the 'big picture' of where you are

Ysurac commented 6 years ago

An easy option: no. But all can be dev.

TomMuc1 commented 6 years ago

ok - but since a day has just 24h not really all is possible. and i have seen many times now how fast you add/alter options for users like me! i'm sure when you say there is no easy option then there is definitely no easy option. so many thanks for reply and for having a look into this mini-map-thing :)

Ysurac commented 6 years ago

I'm working on some features for 3D mode and I try to fix 3D models, this take a long time...

TomMuc1 commented 6 years ago

ok - but i'd spend not too much time with the models. you have already much more aircrafts in flightairmap than i saw in fr24 (i know i'm not allowed to compare). i'd simply threw out the ugly ones with holes and other defects - and use just the shiny ones and use one nice as a dafault for all those were no nice model is availible at the moment ...

TomMuc1 commented 6 years ago

btw - did you see this duesseldorf airport yesterday - wohooo https://www.youtube.com/watch?v=hTT_FpC768M

TomMuc1 commented 6 years ago

YOU ARE THE BEST!!! thank you sooo much for adding this cool new feature :) 'Only display selected flight on 3D mode'

that makes me super happy!!!

https://discussions.flightaware.com/t/flightairmap-watching-your-live-data-next-level/26536/26?u=tommuc

TomMuc1 commented 6 years ago

now fam runs in 3d using less memory, cpu and graphic-card than fr24 and moreover while fma shows higher resolution 3d satellite background image. and i like your start into 3d-mode way more than this silly ground view with the circling to the aircraft fr24 does. i know i don't have to compare :)))

TomMuc1 commented 6 years ago

now load in 3d mode is so low that my newer macbook not even starts to use the dedicated gpu but remains using the intel onboard low-power gpu! and even when i'm in 3d-mode i can switch in sidebar-menu to show all aircrafts (of course then the high end gpu starts up)! great job!!!

Ysurac commented 6 years ago

Now I'm really out for the week-end :)

TomMuc1 commented 6 years ago

yes - and i wish you the best thinkable weekend :) cheers

TomMuc1 commented 6 years ago
TomMuc1 commented 6 years ago

'Only display selected flight on 3D mode' - runs flawless, fast and instantly without any bugs while extensive tests. within all sample sites on cesium website - flightairmap is in top three if not the best implementation of their cesium application :1st_place_medal:

Ysurac commented 6 years ago
TomMuc1 commented 6 years ago
TomMuc1 commented 6 years ago

an additional question in js/map.3d.js.php i set 'shadows : false' but despite that the a380 shows obviously some sort of very nice and smooth shading? see pictures below ...

bildschirmfoto 2017-10-09 um 14 10 48

bildschirmfoto 2017-10-09 um 14 10 58

bildschirmfoto 2017-10-09 um 14 11 07

Ysurac commented 6 years ago
TomMuc1 commented 6 years ago

aah - that's why - looks very nice and natural! unbelievable how big the differences in quality the different models are ...

TomMuc1 commented 6 years ago

anyways - the guy who made the a380 model did a great job :)

TomMuc1 commented 6 years ago

new 3d sun shadow install doest not work. shows 'map3dshadows' instead of true or false in install website and then overwrites existing map3dshadows = FALSE in settings.php

btw. to always have to manually set $globalInstalled = FALSE in settings.php before run install.php again is a little annoying ...

Ysurac commented 6 years ago

Fixed in latest commit. If you don't have to set $globalinstalled to TRUE, anybody that access your website can change settings...

TomMuc1 commented 6 years ago

thanx - works now :)

how about a simple password and password-field in install.php that is stored as md5-hash in settings.php or database

TomMuc1 commented 6 years ago

would be great if there were:

any chance - are there some already existent anywhere?

Ysurac commented 6 years ago

If you don't like models, you can contribute ;) And there is no single models of each type, models are based on aircraft ICAO. Only if the aircraft ICAO model is not available it use a default model of the same type. I also have to use as low possible polygons models, else models use too much memory.

TomMuc1 commented 6 years ago

i did not say you should start modeling new models - and so do i ;) the question was 'are there already existing models that could be included without too much effort' e.g. from sources like this? https://grabcad.com/library/airbus-a380-4

Ysurac commented 6 years ago

No idea of the license, they must have many polygons, not sure I can open them in Blender,... The screenshots are rendered, this will always be better.

TomMuc1 commented 6 years ago

yep that were the same questions i was wondering about :) and yes - no question - over here we render all solidworks models in maxwellrender - and this is totally different to what is possible in realtime! but i thought the modeling is the by far most time consuming part - so it were maybe an option to reuse those existing models and export them to the needed format? no one over here ever used blender so i have no idea about that ...

Ysurac commented 6 years ago

I need to use open license. I also use liveries when available. And again we can have far more beautiful models, but we have the same problems as flightgear (it's why I use models from them): models must have a low number of polygons. Else any models in glTF 1.0 or 2.0 format can be used.

TomMuc1 commented 6 years ago

next week i look with one of our 3d guys into some of those step and solidworks files to see how complex they are. do you have a number or range of polygons that fit to flightairmap e.g. the nice a380 or b777 ?

Ysurac commented 6 years ago

No idea, but file must be as small as possible. For these models it's more nice textures than a good model.

TomMuc1 commented 6 years ago

display actual receiver message rate in aircraft detected layer would be nice (flightaware skyview uses an over 30 seconds averaged value)

$message_rate_array[] = array('messages' => $ac_messages_total, 'time' => $ac_now);
if (time() - $message_rate_array[0]['time'] > 30) array_shift($message_rate_array);
$delta_message_number = $message_rate_array[count($message_rate_array) - 1]['messages'] - $message_rate_array[0]['messages'];
$delta_message_time =  $message_rate_array[count($message_rate_array) - 1]['time'] - $message_rate_array[0]['time'];
$delta_message_time > 0 ? $message_rate = round($delta_message_number / $delta_message_time, '1') : $message_rate = null;
TomMuc1 commented 6 years ago

i know i asked this already - but now using this very cool single aircraft 3d mode since a while these two things are really inconvenient:

Ysurac commented 6 years ago
TomMuc1 commented 6 years ago

regarding the mini-map i don't think that zoomable is really need for - if just the hard set zoom-factor would be say 2 steps lower anything were just perfect :)