search

Yttruire / pe

0 stars 0 forks source link

Incorrect error message for `Schedule` command with missing arguments #7

Open Yttruire opened 2 years ago

Yttruire commented 2 years ago

CLI Input: friend --schedule dracon -p 2 20 2 -f

Expected output: Error message detailing missing arguments for IS_FREE, or at least that the -f arguments are wrong.

Actual output:

image.png

The error message initially says that the day or time format (given by -p flag) is invalid, which is incorrect, it is only the arguments of the -f flag that is incorrect. The -f flag indicates whether the friend is free during that specified day and time, and is not related to day or time itself.

Although it follows with Invalid -p or -f arguments, which is correct, the first sentence in the error message is still erroneous and confusing.

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong error message when scheduling

image.png

Step to reproduce:

  • Enter the command in the screenshot with a valid contact

The first part of the error message is inaccurate -- the -f argument is neither a day or a time. A message such as "wrong boolean value" should have been provided instead.

[original: nus-cs2103-AY2122S1/pe-interim#5195] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]