YuLab-SMU / DOSE

:mask: Disease Ontology Semantic and Enrichment analysis
https://yulab-smu.top/biomedical-knowledge-mining-book/
116 stars 36 forks source link

[Feature Request] Allow conversion to columns other than hgnc symbol #63

Open Nelson-Gon opened 2 years ago

Nelson-Gon commented 2 years ago

Prerequisites

Describe you issue

Ask in right place

Hello,

I was looking at setReadable and was happy to note that this exists and works well for conversion to gene symbols. I think sometimes it may be necessary to convert to an ensembl ID instead and it would be great if there were support for this.

Looking at https://github.com/YuLab-SMU/DOSE/blob/20c57bc217fa9aa17dc642ec047bd80a1848efe5/R/setReadable.R#L53, it seems EXTID2NAME only currently does keytype -> gene symbol conversion.

I envision this would consist of a switch and perhaps an extra argument requesting for the target conversion.

Thank you,

NelsonGon