Changes to try to get Docker to work

YuLab-SMU / MicrobiotaProcessWorkshop

The workshop of microbiome datasets analysis using MicrobiotaProcess

https://yulab-smu.top/MicrobiotaProcessWorkshop/

GNU General Public License v3.0

9 stars 8 forks source link

Changes to try to get Docker to work #1

Closed PeteHaitch closed 4 years ago

PeteHaitch commented 4 years ago

Hi @xiangpin,

I've tried making some changes to the GitHub Actions YAML file to get Docker to work.

Cheers, Pete

PeteHaitch commented 4 years ago

I can't test these myself, but if you merge this PR then GitHub Actions should run and we'll have an answer in a few hours. Fingers crossed

PeteHaitch commented 4 years ago

I wonder if this failed because the 'secrets' have not been added to this github repo? Please see https://seandavi.github.io/BuildABiocWorkshop2020/articles/HOWTO_BUILD_WORKSHOP.html#add-secrets-to-github-repo Did you perform this step?

xiangpin commented 4 years ago

Thanks for your help, I merged the PR, it also be denied, I see the session. But I wonder I I didn't set it up accurately.

xiangpin commented 4 years ago

Now, I has not permission to setting it, since the repository is in the organization.

PeteHaitch commented 4 years ago

Can the repository owner fix this or can you move the repository to your own GitHub?

PeteHaitch commented 4 years ago

Will you be teaching in Chinese or English?

xiangpin commented 4 years ago

Hello Peter, How should I set the secrets. I created Access Tokens on https://hub.docker.com/, then I added the DESCRIPTION of Access Tokens to the secrets of github. But it also be denied.

PeteHaitch commented 4 years ago

Did you follow the instructions in https://seandavi.github.io/BuildABiocWorkshop2020/articles/HOWTO_BUILD_WORKSHOP.html#add-secrets-to-github-repo and https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets?

Unfortunately it's difficult for me to diagnose and fix this problem. I think you need to set the secret at https://github.com/YuLab-SMU/MicrobiotaProcessWorkshop/settings/secrets and be sure to call them:

DOCKER_USERNAME: your dockerhub username; create a dockerhub account if you do not have one
DOCKER_PASSWORD: your dockerhub password or an access token obtained from Docker Hub

xiangpin commented 4 years ago

Yes, I has followed the instructions in the url you provided, but should I create a Access Tokens of DockerHub, then copy it to secrets of github? I has done it, but it didn't work.

PeteHaitch commented 4 years ago

Can you try hosting the repo in your own GitHub account rather than the lab one and set up the secrets there?

xiangpin commented 4 years ago

Thank you very much. I got it. The workflow has passed.

PeteHaitch commented 4 years ago

Great! Thank you again for your contribution to BioC Asia 2020 :)