Closed gaospecial closed 11 months ago
@gaospecial still have many issues:
❯ checking R code for possible problems ... NOTE
tidy_left_subsets: no visible binding for global variable 'item'
tidy_main_subsets: no visible binding for global variable 'id'
tidy_main_subsets: no visible binding for global variable 'name'
tidy_main_subsets: no visible binding for global variable 'item'
tidy_main_subsets: no visible global function definition for 'desc'
tidy_main_subsets: no visible binding for global variable 'item_count'
tidy_main_subsets: no visible global function definition for 'head'
tidy_main_subsets: no visible binding for global variable 'set'
tidy_top_subsets: no visible binding for global variable 'id'
tidy_top_subsets: no visible binding for global variable 'item'
upsetplot_left: no visible binding for global variable 'set'
upsetplot_left: no visible binding for global variable 'item_count'
upsetplot_main: no visible binding for global variable 'id'
upsetplot_main: no visible binding for global variable 'set'
upsetplot_top: no visible binding for global variable 'id'
upsetplot_top: no visible binding for global variable 'item_count'
Undefined global functions or variables:
desc head id item item_count name set
Consider adding
importFrom("utils", "head")
to your NAMESPACE file.
pls fix them.
I merge the code since it works.
My suggestion is to design an object to store all the information we need and several companion functions to get the information for each part.
@gaospecial pls pull your update to https://github.com/YuLab-SMU/aplotExtra.
Reproduce upsetplot using aplot.
see https://github.com/YuLab-SMU/ProjectYulab/issues/3
This is the first version.