search

YuMS / gitlab-ce-pages

Unofficial GitLab Pages for GitLab CE
MIT License
64 stars 11 forks source link

Fixes #18 -- adding an error page directive for custom error pages #20

Closed mechanicjay closed 7 years ago

mechanicjay commented 7 years ago

Adds an error page directive to each vhost. This allows custom 404 pages in the same way the official gitlab pages does: just add a 404.html to your project.

If you don't add a 404.html to your project, the behaviour is the same as today: a generic nginx 404 page.

YuMS commented 7 years ago

Need some tests and document for this.

YuMS commented 7 years ago

After I created some tests and played around with this for a while. I found this solution won't always work because vhost config is only created after you specify a CNAME for a certain project.

For now, I can only make it possible for projects with CNAME to have customizable 404.html and leave a shared 404.html for the rest.

Any idea to solve this divergence?