search

YuMS / gitlab-ce-pages

Unofficial GitLab Pages for GitLab CE
MIT License
64 stars 11 forks source link

Would be cool to have authenticated docs access #7

Open bufferoverflow opened 8 years ago

bufferoverflow commented 8 years ago

Integrating passport-gitlab2 and using GitLab as Authentication provider would allow to build authenticated docs access.

YuMS commented 8 years ago

Sure, having authenticated docs is cool.

But there are several things that may need a bit more thinking.

  1. passport-gitlab2 gives node server power to use oauth2. But actually, static sites are directly backed by NGINX. NGINX Plus seems to support oauth2 (JWT Authentication) but it's not free.
  2. oauth2_proxy is a powerful proxy but it is a little bit heavy to integrate (too many configurable things to expose). I think it may be better to introduce oauth2_proxy in README as an advanced option to provide GitLab oauth2 and even SSL ( #6 ) support.
  3. It's hard to say that giving everyone who has access to GitLab the key to a locked doc is sufficient. It may be enough until GCP is able to give freedom to grant a group of people access to some site and another group of people access to some other sites.
YuMS commented 7 years ago

How about just using a fixed user:pass pair to protect the doc and share it with your group? Is this acceptable? Any pitfall?

http://nginx.org/en/docs/http/ngx_http_auth_basic_module.html