YuSoonZ / pe

0 stars 0 forks source link

Error message for adding meeting schedule #3

Open YuSoonZ opened 1 month ago

YuSoonZ commented 1 month ago

image.png image.png

schedule 5 s/29-02-2025T16:00 e/29-02-2025T20:00 mr/none It was indeed incorrect to use this date since its not a leap year, but this would mean the error message of: Invalid command format! schedule: Schedules a meeting with the person identified by the index number used in the displayed person list. Parameters: INDEX (must be a positive integer) s/START_DATETIME e/END_DATETIME [mr/MEETING_REMARK] Example: schedule 1 s/22-02-2024T14:00 e/22-02-2024T15:00 could be a bit misleading

nus-se-script commented 1 month ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid Date Error not specific

Screenshot 2024-04-19 at 4.30.56 PM.png

Tested: schedule 8 s/30-02-2025T16:00 e/31-04-2025T17:00 mr/test Expected: Raise a specific error that invalid dates have been provided Actual: Vague error message, frustrating the users who have no idea why the application is not accepting the input


[original: nus-cs2103-AY2324S2/pe-interim#27] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the bug report.

We have decided to mark the bug report as not in scope.

We have addressed a similar feature flaw in our planned enhancements, which is to throw an error on which specific field is failing.

image.png

However, we decided that the separation of differentiating between invalid format and invalid value is not in scope as we feel that the planned enhancement will be more helpful by narrowing down to a specific parameter and that the separation of differentiating between invalid format and invalid value should come after this enhancement.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]