search

YuSoonZ / pe

0 stars 0 forks source link

Allowing invalid edit command to work for email addresses #6

Open YuSoonZ opened 1 month ago

YuSoonZ commented 1 month ago

Within UG, it mentioned that email must follow the requirements:

image.png

Running this command: edit 1 e/ABC123@12342.123.6532.123.SADFASD.1231231

image.png

image.png

results in a success, contrasting between what was required as stated within the UG but am still allowed to do it. So its a confusion between UG and the actual implementation

nus-se-bot commented 1 month ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid Email accepted

Screenshot 2024-04-19 at 4.25.02 PM.png

Tested: test@example Expected: Raise error that invalid email is provided Actual: Accepted and edited the person detail with an invalid email

[original: nus-cs2103-AY2324S2/pe-interim#38] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for reporting this bug.

Our team acknowledges this issue that there has some oversight. We feel that this is a feature flaw rather than a functionality bug because our email validation is "incomplete".

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]