search

YuZizhen / pe

0 stars 0 forks source link

Find and Findtags functions can be improved #5

Open YuZizhen opened 7 months ago

YuZizhen commented 7 months ago

image.png I search for john first. Then I try to search for tag "investment".

image.png

This is what it returns. (vise versa)

It seems like the findtagsor and findtagsand function finds the matching tags for all the contacts. For a financial advisor application aiming to have more than 50 contacts, this could probably cause inconvenience for the user.

soc-se-bot commented 7 months ago

Team's Response

The motivation and purpose for the find tags commands was to find for all clients. If the user knows the name of the client, he can simply use the find command. If the user does not know the name but only the plan, he can search by the plans. Having the user search for plans within the find command list will lead to extra steps as the user will have to use the list command to reset the list which can be inconvenient when the user needs to make many searches.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Since clients matching at least one keyword will be returned, even if you know the name of the client, it is hard to search if the contacts stored in the FAPro is large. Moreover, FAPro is targeting at user with a large number of contacts. Thus, it would be even harder for the user to search for a specific client with specific tags if the find tags command must find specific tags in the whole database.